From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: mjt@tls.msk.ru
Subject: [Qemu-devel] [PATCH 2/2] build: more libcacard cleanups
Date: Thu, 8 May 2014 15:08:47 +0200 [thread overview]
Message-ID: <1399554527-22262-3-git-send-email-pbonzini@redhat.com> (raw)
In-Reply-To: <1399554527-22262-1-git-send-email-pbonzini@redhat.com>
To be squashed in Michael's "libcacard: remove libcacard-specific CFLAGS
and LIBS from global vars".
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
configure | 2 --
hw/usb/Makefile.objs | 4 ++--
2 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/configure b/configure
index b0c0c9c..25d59f9 100755
--- a/configure
+++ b/configure
@@ -3470,7 +3470,6 @@ if test "$smartcard_nss" != "no"; then
#include <pk11pub.h>
int main(void) { PK11_FreeSlot(0); return 0; }
EOF
- smartcard_includes="-I\$(SRC_PATH)/libcacard"
# FIXME: do not include $glib_* in here
nss_libs="$($pkg_config --libs nss 2>/dev/null) $glib_libs"
nss_cflags="$($pkg_config --cflags nss 2>/dev/null) $glib_cflags"
@@ -4497,7 +4496,6 @@ fi
if test "$smartcard_nss" = "yes" ; then
echo "CONFIG_SMARTCARD_NSS=y" >> $config_host_mak
- echo "SMARTCARD_INCLUDES=$smartcard_includes" >> $config_host_mak
echo "NSS_LIBS=$nss_libs" >> $config_host_mak
echo "NSS_CFLAGS=$nss_cflags" >> $config_host_mak
fi
diff --git a/hw/usb/Makefile.objs b/hw/usb/Makefile.objs
index 54d3982..a32b38b 100644
--- a/hw/usb/Makefile.objs
+++ b/hw/usb/Makefile.objs
@@ -24,8 +24,8 @@ ifeq ($(CONFIG_USB_SMARTCARD),y)
common-obj-y += dev-smartcard-reader.o
common-obj-y += ccid-card-passthru.o
common-obj-$(CONFIG_SMARTCARD_NSS) += ccid-card-emulated.o
-ccid-card-emulated.o-cflags := $(SMARTCARD_INCLUDES)
-libs_softmmu += $(NSS_LIBS)
+ccid-card-emulated.o-cflags := -I$(SRC_PATH)/libcacard
+ccid-card-emulated.o-libs += $(NSS_LIBS)
endif
ifeq ($(CONFIG_POSIX),y)
--
1.8.3.1
next prev parent reply other threads:[~2014-05-08 13:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-08 13:08 [Qemu-devel] [PATCH 0/2] build: simplify and fix fix-obj-vars, more libcacard cleanups Paolo Bonzini
2014-05-08 13:08 ` [Qemu-devel] [PATCH 1/2] build: simplify and fix fix-obj-vars Paolo Bonzini
2014-05-08 13:40 ` Fam Zheng
2014-05-08 14:39 ` Paolo Bonzini
2014-05-08 13:08 ` Paolo Bonzini [this message]
2014-05-08 13:16 ` [Qemu-devel] [PATCH 2/2] build: more libcacard cleanups Michael Tokarev
2014-05-08 13:28 ` Paolo Bonzini
2014-05-08 13:33 ` Michael Tokarev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1399554527-22262-3-git-send-email-pbonzini@redhat.com \
--to=pbonzini@redhat.com \
--cc=mjt@tls.msk.ru \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).