From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: Fam Zheng <famz@redhat.com>, mjt@tls.msk.ru
Subject: [Qemu-devel] [PATCH 06/10] Makefile: use $(INSTALL_LIB) for modules not $(INSTALL_PROG)
Date: Thu, 8 May 2014 15:36:34 +0200 [thread overview]
Message-ID: <1399556198-17776-7-git-send-email-pbonzini@redhat.com> (raw)
In-Reply-To: <1399556198-17776-1-git-send-email-pbonzini@redhat.com>
From: Michael Tokarev <mjt@tls.msk.ru>
We have $(INSTALL_LIB) which is the same as $(INSTALL_PROG) but
uses correct permissions. Loadable objects (modules) are like
shared libraries, not like programs.
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
Cc: Fam Zheng <famz@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Makefile b/Makefile
index 23ca444..12ea464 100644
--- a/Makefile
+++ b/Makefile
@@ -381,7 +381,7 @@ ifneq ($(CONFIG_MODULES),)
$(INSTALL_DIR) "$(DESTDIR)$(qemu_moddir)"
for s in $(modules-m:.mo=$(DSOSUF)); do \
t="$(DESTDIR)$(qemu_moddir)/$$(echo $$s | tr / -)"; \
- $(INSTALL_PROG) $$s "$$t"; \
+ $(INSTALL_LIB) $$s "$$t"; \
test -z "$(STRIP)" || $(STRIP) "$$t"; \
done
endif
--
1.8.3.1
next prev parent reply other threads:[~2014-05-08 13:37 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-08 13:36 [Qemu-devel] [PATCH 00/10] build: pending fixes and improvements Paolo Bonzini
2014-05-08 13:36 ` [Qemu-devel] [PATCH 01/10] build: Fix per-object variables for Makefile.target Paolo Bonzini
2014-05-08 13:36 ` [Qemu-devel] [PATCH 02/10] build: simplify Makefile.target a bit, use just one rule for softmmu Paolo Bonzini
2014-05-08 13:36 ` [Qemu-devel] [PATCH 03/10] build: simplify Makefile.target around unnest-vars invocations Paolo Bonzini
2014-05-08 13:36 ` [Qemu-devel] [PATCH 04/10] Makefile: strip tools and modules too Paolo Bonzini
2014-05-08 13:36 ` [Qemu-devel] [PATCH 05/10] Makefile.target: use $(INSTALL_PROG) for installing, not $(INSTALL) Paolo Bonzini
2014-05-08 13:36 ` Paolo Bonzini [this message]
2014-05-08 13:36 ` [Qemu-devel] [PATCH 07/10] build: add support for per-object -cflags and -libs to all rules Paolo Bonzini
2014-05-08 13:36 ` [Qemu-devel] [PATCH 08/10] build: convert some obj-specific CFLAGS to use new foo.o-cflags syntax Paolo Bonzini
2014-05-08 13:36 ` [Qemu-devel] [PATCH 09/10] build: simplify and fix fix-obj-vars Paolo Bonzini
2014-05-08 13:53 ` Michael Tokarev
2014-05-08 14:30 ` Paolo Bonzini
2014-05-08 13:36 ` [Qemu-devel] [PATCH 10/10] libcacard: remove libcacard-specific CFLAGS and LIBS from global vars Paolo Bonzini
2014-05-08 14:50 ` Michael Tokarev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1399556198-17776-7-git-send-email-pbonzini@redhat.com \
--to=pbonzini@redhat.com \
--cc=famz@redhat.com \
--cc=mjt@tls.msk.ru \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).