From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54030) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WiOVU-0002z8-Um for qemu-devel@nongnu.org; Thu, 08 May 2014 09:37:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WiOVP-0006ma-AK for qemu-devel@nongnu.org; Thu, 08 May 2014 09:37:04 -0400 Received: from mail-we0-x22c.google.com ([2a00:1450:400c:c03::22c]:56569) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WiOVP-0006mL-3Z for qemu-devel@nongnu.org; Thu, 08 May 2014 09:36:59 -0400 Received: by mail-we0-f172.google.com with SMTP id k48so2565026wev.3 for ; Thu, 08 May 2014 06:36:58 -0700 (PDT) Sender: Paolo Bonzini From: Paolo Bonzini Date: Thu, 8 May 2014 15:36:34 +0200 Message-Id: <1399556198-17776-7-git-send-email-pbonzini@redhat.com> In-Reply-To: <1399556198-17776-1-git-send-email-pbonzini@redhat.com> References: <1399556198-17776-1-git-send-email-pbonzini@redhat.com> Subject: [Qemu-devel] [PATCH 06/10] Makefile: use $(INSTALL_LIB) for modules not $(INSTALL_PROG) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Fam Zheng , mjt@tls.msk.ru From: Michael Tokarev We have $(INSTALL_LIB) which is the same as $(INSTALL_PROG) but uses correct permissions. Loadable objects (modules) are like shared libraries, not like programs. Signed-off-by: Michael Tokarev Cc: Fam Zheng Cc: Paolo Bonzini Signed-off-by: Paolo Bonzini --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 23ca444..12ea464 100644 --- a/Makefile +++ b/Makefile @@ -381,7 +381,7 @@ ifneq ($(CONFIG_MODULES),) $(INSTALL_DIR) "$(DESTDIR)$(qemu_moddir)" for s in $(modules-m:.mo=$(DSOSUF)); do \ t="$(DESTDIR)$(qemu_moddir)/$$(echo $$s | tr / -)"; \ - $(INSTALL_PROG) $$s "$$t"; \ + $(INSTALL_LIB) $$s "$$t"; \ test -z "$(STRIP)" || $(STRIP) "$$t"; \ done endif -- 1.8.3.1