From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35839) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WiPCZ-0006g3-R7 for qemu-devel@nongnu.org; Thu, 08 May 2014 10:21:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WiPCL-0005vT-K6 for qemu-devel@nongnu.org; Thu, 08 May 2014 10:21:35 -0400 Received: from cantor2.suse.de ([195.135.220.15]:52620 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WiPCL-0005v1-Cw for qemu-devel@nongnu.org; Thu, 08 May 2014 10:21:21 -0400 From: =?UTF-8?q?Andreas=20F=C3=A4rber?= Date: Thu, 8 May 2014 16:21:17 +0200 Message-Id: <1399558877-4915-5-git-send-email-afaerber@suse.de> In-Reply-To: <1399558877-4915-1-git-send-email-afaerber@suse.de> References: <1399558877-4915-1-git-send-email-afaerber@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: [Qemu-devel] [PATCH qom-next 4/4] qom: Implement qom-set HMP command List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Andreas=20F=C3=A4rber?= , Luiz Capitulino Re-implemented based on qmp_qom_set() to facilitate argument parsing. Signed-off-by: Andreas F=C3=A4rber --- hmp-commands.hx | 13 +++++++++++++ hmp.c | 18 ++++++++++++++++++ hmp.h | 1 + 3 files changed, 32 insertions(+) diff --git a/hmp-commands.hx b/hmp-commands.hx index c0603e9..73145b7 100644 --- a/hmp-commands.hx +++ b/hmp-commands.hx @@ -1704,6 +1704,19 @@ Print QOM property @var{property} of object at loc= ation @var{path} ETEXI =20 { + .name =3D "qom-set", + .args_type =3D "path:s,property:s,value:s", + .params =3D "path property value", + .help =3D "set QOM property", + .mhandler.cmd =3D hmp_qom_set, + }, + +STEXI +@item qom-set @var{path} @var{property} @var{value} +Set QOM property @var{property} of object at location @var{path} to valu= e @var{value} +ETEXI + + { .name =3D "info", .args_type =3D "item:s?", .params =3D "[subcommand]", diff --git a/hmp.c b/hmp.c index d7d7a98..1cc2e60 100644 --- a/hmp.c +++ b/hmp.c @@ -1715,3 +1715,21 @@ void hmp_qom_get(Monitor *mon, const QDict *qdict) } hmp_handle_error(mon, &err); } + +void hmp_qom_set(Monitor *mon, const QDict *qdict) +{ + const char *path =3D qdict_get_str(qdict, "path"); + const char *property =3D qdict_get_str(qdict, "property"); + const char *value =3D qdict_get_str(qdict, "value"); + Error *err =3D NULL; + Object *obj; + + obj =3D object_resolve_path(path, NULL); + if (obj =3D=3D NULL) { + error_set(&err, QERR_DEVICE_NOT_FOUND, path); + hmp_handle_error(mon, &err); + return; + } + object_property_parse(obj, value, property, &err); + hmp_handle_error(mon, &err); +} diff --git a/hmp.h b/hmp.h index 269d99e..6b7b1da 100644 --- a/hmp.h +++ b/hmp.h @@ -95,6 +95,7 @@ void hmp_object_add(Monitor *mon, const QDict *qdict); void hmp_object_del(Monitor *mon, const QDict *qdict); void hmp_qom_list(Monitor *mon, const QDict *qdict); void hmp_qom_get(Monitor *mon, const QDict *qdict); +void hmp_qom_set(Monitor *mon, const QDict *qdict); void object_add_completion(ReadLineState *rs, int nb_args, const char *s= tr); void object_del_completion(ReadLineState *rs, int nb_args, const char *s= tr); void device_add_completion(ReadLineState *rs, int nb_args, const char *s= tr); --=20 1.8.4.5