From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52781) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WiRQq-0006Am-5i for qemu-devel@nongnu.org; Thu, 08 May 2014 12:44:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WiRQj-0003H6-Sw for qemu-devel@nongnu.org; Thu, 08 May 2014 12:44:28 -0400 Received: from mx1.redhat.com ([209.132.183.28]:26753) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WiRQj-0003Gn-Lt for qemu-devel@nongnu.org; Thu, 08 May 2014 12:44:21 -0400 From: Paolo Bonzini Date: Thu, 8 May 2014 18:09:44 +0200 Message-Id: <1399565391-27833-5-git-send-email-pbonzini@redhat.com> In-Reply-To: <1399565391-27833-1-git-send-email-pbonzini@redhat.com> References: <1399565391-27833-1-git-send-email-pbonzini@redhat.com> Subject: [Qemu-devel] [RFC PATCH 04/11] softmmu: move definition of CPU_MMU_INDEX to inclusion site, drop ACCESS_TYPE List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, rth@twiddle.net Signed-off-by: Paolo Bonzini --- include/exec/exec-all.h | 4 ++-- include/exec/softmmu_exec.h | 28 ++++++++++++++-------------- include/exec/softmmu_header.h | 11 ----------- 3 files changed, 16 insertions(+), 27 deletions(-) diff --git a/include/exec/exec-all.h b/include/exec/exec-all.h index 63713ba..3696e9d 100644 --- a/include/exec/exec-all.h +++ b/include/exec/exec-all.h @@ -340,7 +340,7 @@ uint16_t helper_ldw_cmmu(CPUArchState *env, target_ulong addr, int mmu_idx); uint32_t helper_ldl_cmmu(CPUArchState *env, target_ulong addr, int mmu_idx); uint64_t helper_ldq_cmmu(CPUArchState *env, target_ulong addr, int mmu_idx); -#define ACCESS_TYPE (NB_MMU_MODES + 1) +#define CPU_MMU_INDEX (cpu_mmu_index(env)) #define MEMSUFFIX _code #define SOFTMMU_CODE_ACCESS @@ -356,7 +356,7 @@ uint64_t helper_ldq_cmmu(CPUArchState *env, target_ulong addr, int mmu_idx); #define DATA_SIZE 8 #include "exec/softmmu_header.h" -#undef ACCESS_TYPE +#undef CPU_MMU_INDEX #undef MEMSUFFIX #undef SOFTMMU_CODE_ACCESS diff --git a/include/exec/softmmu_exec.h b/include/exec/softmmu_exec.h index 470db20..8217733 100644 --- a/include/exec/softmmu_exec.h +++ b/include/exec/softmmu_exec.h @@ -22,7 +22,7 @@ /* The memory helpers for tcg-generated code need tcg_target_long etc. */ #include "tcg.h" -#define ACCESS_TYPE 0 +#define CPU_MMU_INDEX 0 #define MEMSUFFIX MMU_MODE0_SUFFIX #define DATA_SIZE 1 #include "exec/softmmu_header.h" @@ -35,10 +35,10 @@ #define DATA_SIZE 8 #include "exec/softmmu_header.h" -#undef ACCESS_TYPE +#undef CPU_MMU_INDEX #undef MEMSUFFIX -#define ACCESS_TYPE 1 +#define CPU_MMU_INDEX 1 #define MEMSUFFIX MMU_MODE1_SUFFIX #define DATA_SIZE 1 #include "exec/softmmu_header.h" @@ -51,12 +51,12 @@ #define DATA_SIZE 8 #include "exec/softmmu_header.h" -#undef ACCESS_TYPE +#undef CPU_MMU_INDEX #undef MEMSUFFIX #if (NB_MMU_MODES >= 3) -#define ACCESS_TYPE 2 +#define CPU_MMU_INDEX 2 #define MEMSUFFIX MMU_MODE2_SUFFIX #define DATA_SIZE 1 #include "exec/softmmu_header.h" @@ -69,13 +69,13 @@ #define DATA_SIZE 8 #include "exec/softmmu_header.h" -#undef ACCESS_TYPE +#undef CPU_MMU_INDEX #undef MEMSUFFIX #endif /* (NB_MMU_MODES >= 3) */ #if (NB_MMU_MODES >= 4) -#define ACCESS_TYPE 3 +#define CPU_MMU_INDEX 3 #define MEMSUFFIX MMU_MODE3_SUFFIX #define DATA_SIZE 1 #include "exec/softmmu_header.h" @@ -88,13 +88,13 @@ #define DATA_SIZE 8 #include "exec/softmmu_header.h" -#undef ACCESS_TYPE +#undef CPU_MMU_INDEX #undef MEMSUFFIX #endif /* (NB_MMU_MODES >= 4) */ #if (NB_MMU_MODES >= 5) -#define ACCESS_TYPE 4 +#define CPU_MMU_INDEX 4 #define MEMSUFFIX MMU_MODE4_SUFFIX #define DATA_SIZE 1 #include "exec/softmmu_header.h" @@ -107,13 +107,13 @@ #define DATA_SIZE 8 #include "exec/softmmu_header.h" -#undef ACCESS_TYPE +#undef CPU_MMU_INDEX #undef MEMSUFFIX #endif /* (NB_MMU_MODES >= 5) */ #if (NB_MMU_MODES >= 6) -#define ACCESS_TYPE 5 +#define CPU_MMU_INDEX 5 #define MEMSUFFIX MMU_MODE5_SUFFIX #define DATA_SIZE 1 #include "exec/softmmu_header.h" @@ -126,7 +126,7 @@ #define DATA_SIZE 8 #include "exec/softmmu_header.h" -#undef ACCESS_TYPE +#undef CPU_MMU_INDEX #undef MEMSUFFIX #endif /* (NB_MMU_MODES >= 6) */ @@ -135,7 +135,7 @@ #endif /* (NB_MMU_MODES > 6) */ /* these access are slower, they must be as rare as possible */ -#define ACCESS_TYPE (NB_MMU_MODES) +#define CPU_MMU_INDEX (cpu_mmu_index(env)) #define MEMSUFFIX _data #define DATA_SIZE 1 #include "exec/softmmu_header.h" @@ -148,7 +148,7 @@ #define DATA_SIZE 8 #include "exec/softmmu_header.h" -#undef ACCESS_TYPE +#undef CPU_MMU_INDEX #undef MEMSUFFIX #define ldub(p) ldub_data(p) diff --git a/include/exec/softmmu_header.h b/include/exec/softmmu_header.h index cc85a43..bb18f97 100644 --- a/include/exec/softmmu_header.h +++ b/include/exec/softmmu_header.h @@ -47,16 +47,6 @@ #error unsupported data size #endif -#if ACCESS_TYPE < (NB_MMU_MODES) -#define CPU_MMU_INDEX ACCESS_TYPE -#elif ACCESS_TYPE == (NB_MMU_MODES) -#define CPU_MMU_INDEX (cpu_mmu_index(env)) -#elif ACCESS_TYPE == (NB_MMU_MODES + 1) -#define CPU_MMU_INDEX (cpu_mmu_index(env)) -#else -#error invalid ACCESS_TYPE -#endif - #if DATA_SIZE == 8 #define RES_TYPE uint64_t #else @@ -199,6 +189,5 @@ static inline void glue(cpu_stfl, MEMSUFFIX)(CPUArchState *env, #undef SUFFIX #undef USUFFIX #undef DATA_SIZE -#undef CPU_MMU_INDEX #undef MMUSUFFIX #undef ADDR_READ -- 1.8.3.1