From: Max Reitz <mreitz@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Kevin Wolf" <kwolf@redhat.com>,
"Benoît Canet" <benoit@irqsave.net>,
"Stefan Hajnoczi" <stefanha@redhat.com>,
"Max Reitz" <mreitz@redhat.com>
Subject: [Qemu-devel] [PATCH v3 0/4] block: Allow JSON filenames
Date: Thu, 8 May 2014 20:12:38 +0200 [thread overview]
Message-ID: <1399572762-13990-1-git-send-email-mreitz@redhat.com> (raw)
This series acts as some kind of alternative or v6 to the "block/json:
Add JSON protocol driver" series. It makes bdrv_open() parse filenames
prefixed by "json:" as JSON objects (discarding the prefix beforehand)
and then use the resulting QDict as the options for the block device to
be opened with a NULL filename.
The purpose of this is that it may sometimes be desirable to specify
options for a block device where only a filename can be given, e.g., for
backing files. Using this should obviously be the exception, but it is
nice to have if actually needed.
After having written this series, I do indeed agree that it is much
nicer than the old version of having a dedicated "virtual" block driver
for this purpose.
Patches 1 and 2 are taken directly from the block/json v3, patch 4 has
been enriched by an additional scenario (options given both directly and
through the filename) and its comments have been adapted to the new
implementation.
v3:
- Prioritize options given directly over those in the filename, as the
use case for this series is being able to implicitly specify options
e.g. for a backing file; a user should be able to override those,
however [Kevin]
- Adapted the test case in patch 4 accordingly
git-backport-diff against v2:
Key:
[----] : patches are identical
[####] : number of functional differences between upstream/downstream patch
[down] : patch is downstream-only
The flags [FC] indicate (F)unctional and (C)ontextual differences, respectively
001/4:[----] [--] 'qdict: Add qdict_join()'
002/4:[----] [--] 'check-qdict: Add test for qdict_join()'
003/4:[0010] [FC] 'block: Allow JSON filenames'
004/4:[0015] [FC] 'iotests: Add test for the JSON protocol'
Max Reitz (4):
qdict: Add qdict_join()
check-qdict: Add test for qdict_join()
block: Allow JSON filenames
iotests: Add test for the JSON protocol
block.c | 41 ++++++++++++++
include/qapi/qmp/qdict.h | 3 ++
qobject/qdict.c | 32 +++++++++++
tests/check-qdict.c | 87 ++++++++++++++++++++++++++++++
tests/qemu-iotests/089 | 130 +++++++++++++++++++++++++++++++++++++++++++++
tests/qemu-iotests/089.out | 54 +++++++++++++++++++
tests/qemu-iotests/group | 1 +
7 files changed, 348 insertions(+)
create mode 100755 tests/qemu-iotests/089
create mode 100644 tests/qemu-iotests/089.out
--
1.9.2
next reply other threads:[~2014-05-08 18:13 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-08 18:12 Max Reitz [this message]
2014-05-08 18:12 ` [Qemu-devel] [PATCH v3 1/4] qdict: Add qdict_join() Max Reitz
2014-05-08 18:12 ` [Qemu-devel] [PATCH v3 2/4] check-qdict: Add test for qdict_join() Max Reitz
2014-05-08 18:12 ` [Qemu-devel] [PATCH v3 3/4] block: Allow JSON filenames Max Reitz
2014-05-13 22:12 ` Eric Blake
2014-05-14 10:52 ` Kevin Wolf
2014-05-08 18:12 ` [Qemu-devel] [PATCH v3 4/4] iotests: Add test for the JSON protocol Max Reitz
2014-05-13 22:21 ` Eric Blake
2014-05-19 14:25 ` Kevin Wolf
2014-05-14 10:52 ` [Qemu-devel] [PATCH v3 0/4] block: Allow JSON filenames Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1399572762-13990-1-git-send-email-mreitz@redhat.com \
--to=mreitz@redhat.com \
--cc=benoit@irqsave.net \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).