From: Peter Maydell <peter.maydell@linaro.org>
To: qemu-devel@nongnu.org
Cc: Peter Crosthwaite <peter.crosthwaite@xilinx.com>, patches@linaro.org
Subject: [Qemu-devel] [PATCH 2/8] hw/net/cadence_gem: Remove dead code
Date: Thu, 8 May 2014 19:46:52 +0100 [thread overview]
Message-ID: <1399574818-19349-3-git-send-email-peter.maydell@linaro.org> (raw)
In-Reply-To: <1399574818-19349-1-git-send-email-peter.maydell@linaro.org>
Commit 191946c moved the code to handle padding to minimum
length from after the handling of the CRC to before it.
This means that the CRC code doesn't need to cope with the
possibility that the size is less than 60; remove this
dead code.
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
hw/net/cadence_gem.c | 8 +-------
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/hw/net/cadence_gem.c b/hw/net/cadence_gem.c
index cdb1825..afddc8a 100644
--- a/hw/net/cadence_gem.c
+++ b/hw/net/cadence_gem.c
@@ -717,7 +717,6 @@ static ssize_t gem_receive(NetClientState *nc, const uint8_t *buf, size_t size)
rxbuf_ptr = (void *)buf;
} else {
unsigned crc_val;
- int crc_offset;
/* The application wants the FCS field, which QEMU does not provide.
* We must try and caclculate one.
@@ -727,12 +726,7 @@ static ssize_t gem_receive(NetClientState *nc, const uint8_t *buf, size_t size)
memset(rxbuf + size, 0, sizeof(rxbuf) - size);
rxbuf_ptr = rxbuf;
crc_val = cpu_to_le32(crc32(0, rxbuf, MAX(size, 60)));
- if (size < 60) {
- crc_offset = 60;
- } else {
- crc_offset = size;
- }
- memcpy(rxbuf + crc_offset, &crc_val, sizeof(crc_val));
+ memcpy(rxbuf + size, &crc_val, sizeof(crc_val));
bytes_to_copy += 4;
size += 4;
--
1.9.2
next prev parent reply other threads:[~2014-05-08 18:47 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-08 18:46 [Qemu-devel] [PATCH 0/8] misc fixes for coverity warnings in ARM devices Peter Maydell
2014-05-08 18:46 ` [Qemu-devel] [PATCH 1/8] hw/intc/allwinner-a10-pic: Add missing 'break' Peter Maydell
2014-05-09 22:45 ` Peter Crosthwaite
2014-05-08 18:46 ` Peter Maydell [this message]
2014-05-09 22:50 ` [Qemu-devel] [PATCH 2/8] hw/net/cadence_gem: Remove dead code Peter Crosthwaite
2014-05-08 18:46 ` [Qemu-devel] [PATCH 3/8] hw/display/pxa2xx_lcd: Fix 16bpp+alpha and 18bpp+alpha palette formats Peter Maydell
2014-05-09 23:35 ` Peter Crosthwaite
2014-05-13 15:23 ` Peter Maydell
2014-05-08 18:46 ` [Qemu-devel] [PATCH 4/8] hw/arm/omap1: Avoid unintended sign extension writing omap_rtc YEARS_REG Peter Maydell
2014-05-09 23:45 ` Peter Crosthwaite
2014-05-08 18:46 ` [Qemu-devel] [PATCH 5/8] hw/dma/omap_dma: Add (uint32_t) casts when shifting uint16_t by 16 Peter Maydell
2014-05-09 23:47 ` Peter Crosthwaite
2014-05-08 18:46 ` [Qemu-devel] [PATCH 6/8] hw/timer/exynos4210_mct: Avoid overflow in exynos4210_ltick_recalc_count Peter Maydell
2014-05-09 23:49 ` Peter Crosthwaite
2014-05-08 18:46 ` [Qemu-devel] [PATCH 7/8] hw/arm/stellaris: Correct handling of GPTM TAR register Peter Maydell
2014-05-10 12:33 ` Peter Crosthwaite
2014-05-10 13:48 ` Peter Maydell
2014-05-08 18:46 ` [Qemu-devel] [PATCH 8/8] hw/arm/omap_gpmc: Avoid buffer overrun filling prefetch FIFO Peter Maydell
2014-05-10 12:55 ` Peter Crosthwaite
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1399574818-19349-3-git-send-email-peter.maydell@linaro.org \
--to=peter.maydell@linaro.org \
--cc=patches@linaro.org \
--cc=peter.crosthwaite@xilinx.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).