qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Peter Maydell <peter.maydell@linaro.org>
To: qemu-devel@nongnu.org
Cc: Peter Crosthwaite <peter.crosthwaite@xilinx.com>, patches@linaro.org
Subject: [Qemu-devel] [PATCH 6/8] hw/timer/exynos4210_mct: Avoid overflow in exynos4210_ltick_recalc_count
Date: Thu,  8 May 2014 19:46:56 +0100	[thread overview]
Message-ID: <1399574818-19349-7-git-send-email-peter.maydell@linaro.org> (raw)
In-Reply-To: <1399574818-19349-1-git-send-email-peter.maydell@linaro.org>

Add casts to avoid potentially overflowing the multiplications
of 32 bit quantities in exynos4210_ltick_recalc_count().

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
 hw/timer/exynos4210_mct.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/hw/timer/exynos4210_mct.c b/hw/timer/exynos4210_mct.c
index 86f4fcd..69dbecd 100644
--- a/hw/timer/exynos4210_mct.c
+++ b/hw/timer/exynos4210_mct.c
@@ -824,14 +824,14 @@ static void exynos4210_ltick_recalc_count(struct tick_timer *s)
          */
 
         if (s->last_tcnto) {
-            to_count = s->last_tcnto * s->last_icnto;
+            to_count = (uint64_t)s->last_tcnto * s->last_icnto;
         } else {
             to_count = s->last_icnto;
         }
     } else {
         /* distance is passed, recalculate with tcnto * icnto */
         if (s->icntb) {
-            s->distance = s->tcntb * s->icntb;
+            s->distance = (uint64_t)s->tcntb * s->icntb;
         } else {
             s->distance = s->tcntb;
         }
-- 
1.9.2

  parent reply	other threads:[~2014-05-08 18:47 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-08 18:46 [Qemu-devel] [PATCH 0/8] misc fixes for coverity warnings in ARM devices Peter Maydell
2014-05-08 18:46 ` [Qemu-devel] [PATCH 1/8] hw/intc/allwinner-a10-pic: Add missing 'break' Peter Maydell
2014-05-09 22:45   ` Peter Crosthwaite
2014-05-08 18:46 ` [Qemu-devel] [PATCH 2/8] hw/net/cadence_gem: Remove dead code Peter Maydell
2014-05-09 22:50   ` Peter Crosthwaite
2014-05-08 18:46 ` [Qemu-devel] [PATCH 3/8] hw/display/pxa2xx_lcd: Fix 16bpp+alpha and 18bpp+alpha palette formats Peter Maydell
2014-05-09 23:35   ` Peter Crosthwaite
2014-05-13 15:23     ` Peter Maydell
2014-05-08 18:46 ` [Qemu-devel] [PATCH 4/8] hw/arm/omap1: Avoid unintended sign extension writing omap_rtc YEARS_REG Peter Maydell
2014-05-09 23:45   ` Peter Crosthwaite
2014-05-08 18:46 ` [Qemu-devel] [PATCH 5/8] hw/dma/omap_dma: Add (uint32_t) casts when shifting uint16_t by 16 Peter Maydell
2014-05-09 23:47   ` Peter Crosthwaite
2014-05-08 18:46 ` Peter Maydell [this message]
2014-05-09 23:49   ` [Qemu-devel] [PATCH 6/8] hw/timer/exynos4210_mct: Avoid overflow in exynos4210_ltick_recalc_count Peter Crosthwaite
2014-05-08 18:46 ` [Qemu-devel] [PATCH 7/8] hw/arm/stellaris: Correct handling of GPTM TAR register Peter Maydell
2014-05-10 12:33   ` Peter Crosthwaite
2014-05-10 13:48     ` Peter Maydell
2014-05-08 18:46 ` [Qemu-devel] [PATCH 8/8] hw/arm/omap_gpmc: Avoid buffer overrun filling prefetch FIFO Peter Maydell
2014-05-10 12:55   ` Peter Crosthwaite

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1399574818-19349-7-git-send-email-peter.maydell@linaro.org \
    --to=peter.maydell@linaro.org \
    --cc=patches@linaro.org \
    --cc=peter.crosthwaite@xilinx.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).