* [Qemu-devel] [PATCH] bsd-user: Remove reference to CONFIG_UNAME_RELEASE
@ 2014-05-09 15:06 Peter Maydell
2014-05-13 12:30 ` Peter Maydell
0 siblings, 1 reply; 2+ messages in thread
From: Peter Maydell @ 2014-05-09 15:06 UTC (permalink / raw)
To: qemu-devel; +Cc: Blue Swirl, Riku Voipio, Brad Smith, patches
Commit e586822a5 broke the bsd-user build when it removed the
CONFIG_UNAME_RELEASE define but forgot to remove the use of it
in bsd-user. Fix this in the simplest possible way (bsd-user
doesn't make any use at all of the qemu_uname_release variable
except to allow it to be pointlessly set by the user, so this
is all we need to do.)
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
Not even compile tested, since I don't have a BSD system to
hand. If somebody would like to provide a Tested-by: then
I'll apply it to master...
bsd-user/main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/bsd-user/main.c b/bsd-user/main.c
index f81ba55..0f9169d 100644
--- a/bsd-user/main.c
+++ b/bsd-user/main.c
@@ -43,7 +43,7 @@ unsigned long reserved_va;
#endif
static const char *interp_prefix = CONFIG_QEMU_INTERP_PREFIX;
-const char *qemu_uname_release = CONFIG_UNAME_RELEASE;
+const char *qemu_uname_release;
extern char **environ;
enum BSDType bsd_type;
--
1.9.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [PATCH] bsd-user: Remove reference to CONFIG_UNAME_RELEASE
2014-05-09 15:06 [Qemu-devel] [PATCH] bsd-user: Remove reference to CONFIG_UNAME_RELEASE Peter Maydell
@ 2014-05-13 12:30 ` Peter Maydell
0 siblings, 0 replies; 2+ messages in thread
From: Peter Maydell @ 2014-05-13 12:30 UTC (permalink / raw)
To: QEMU Developers; +Cc: Blue Swirl, Riku Voipio, Patch Tracking, Brad Smith
On 9 May 2014 16:06, Peter Maydell <peter.maydell@linaro.org> wrote:
> Commit e586822a5 broke the bsd-user build when it removed the
> CONFIG_UNAME_RELEASE define but forgot to remove the use of it
> in bsd-user. Fix this in the simplest possible way (bsd-user
> doesn't make any use at all of the qemu_uname_release variable
> except to allow it to be pointlessly set by the user, so this
> is all we need to do.)
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> Not even compile tested, since I don't have a BSD system to
> hand. If somebody would like to provide a Tested-by: then
> I'll apply it to master...
In the absence of any testers I applied it anyway...
thanks
-- PMM
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-05-13 12:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-05-09 15:06 [Qemu-devel] [PATCH] bsd-user: Remove reference to CONFIG_UNAME_RELEASE Peter Maydell
2014-05-13 12:30 ` Peter Maydell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).