From: Stefan Hajnoczi <stefanha@redhat.com>
To: qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>,
Fam Zheng <famz@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>
Subject: [Qemu-devel] [PULL 07/17] vmdk: Implement .bdrv_write_compressed
Date: Fri, 9 May 2014 21:03:27 +0200 [thread overview]
Message-ID: <1399662217-31148-8-git-send-email-stefanha@redhat.com> (raw)
In-Reply-To: <1399662217-31148-1-git-send-email-stefanha@redhat.com>
From: Fam Zheng <famz@redhat.com>
Add a wrapper function to support "compressed" path in qemu-img convert.
Only support streamOptimized subformat case for now (num_extents == 1
and extent compression is true).
Signed-off-by: Fam Zheng <famz@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
block/vmdk.c | 14 ++++++++++++++
1 file changed, 14 insertions(+)
diff --git a/block/vmdk.c b/block/vmdk.c
index 06a1f9f..057c3f1 100644
--- a/block/vmdk.c
+++ b/block/vmdk.c
@@ -1496,6 +1496,19 @@ static coroutine_fn int vmdk_co_write(BlockDriverState *bs, int64_t sector_num,
return ret;
}
+static int vmdk_write_compressed(BlockDriverState *bs,
+ int64_t sector_num,
+ const uint8_t *buf,
+ int nb_sectors)
+{
+ BDRVVmdkState *s = bs->opaque;
+ if (s->num_extents == 1 && s->extents[0].compressed) {
+ return vmdk_write(bs, sector_num, buf, nb_sectors, false, false);
+ } else {
+ return -ENOTSUP;
+ }
+}
+
static int coroutine_fn vmdk_co_write_zeroes(BlockDriverState *bs,
int64_t sector_num,
int nb_sectors,
@@ -2109,6 +2122,7 @@ static BlockDriver bdrv_vmdk = {
.bdrv_reopen_prepare = vmdk_reopen_prepare,
.bdrv_read = vmdk_co_read,
.bdrv_write = vmdk_co_write,
+ .bdrv_write_compressed = vmdk_write_compressed,
.bdrv_co_write_zeroes = vmdk_co_write_zeroes,
.bdrv_close = vmdk_close,
.bdrv_create = vmdk_create,
--
1.9.0
next prev parent reply other threads:[~2014-05-09 19:04 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-09 19:03 [Qemu-devel] [PULL 00/17] Block patches Stefan Hajnoczi
2014-05-09 19:03 ` [Qemu-devel] [PULL 01/17] qcow2: Fix alloc_clusters_noref() overflow detection Stefan Hajnoczi
2014-05-09 19:03 ` [Qemu-devel] [PULL 02/17] iotests: Use configured python Stefan Hajnoczi
2014-05-09 19:03 ` [Qemu-devel] [PULL 03/17] qemu-img: sort block formats in help message Stefan Hajnoczi
2014-05-13 14:18 ` Cornelia Huck
2014-05-13 15:40 ` Mike Day
2014-05-14 12:35 ` Stefan Hajnoczi
2014-05-14 13:27 ` Mike Day
2014-05-14 13:40 ` Fam Zheng
2014-05-14 13:46 ` Jeff Cody
2014-05-14 13:43 ` Jeff Cody
2014-05-14 14:03 ` Mike Day
2014-05-09 19:03 ` [Qemu-devel] [PULL 04/17] block/nfs: Check for NULL server part Stefan Hajnoczi
2014-05-09 19:03 ` [Qemu-devel] [PULL 05/17] block/iscsi: bump year in copyright notice Stefan Hajnoczi
2014-05-09 19:03 ` [Qemu-devel] [PULL 06/17] qemu-img: Convert by cluster size if target is compressed Stefan Hajnoczi
2014-05-09 19:03 ` Stefan Hajnoczi [this message]
2014-05-09 19:03 ` [Qemu-devel] [PULL 08/17] vmdk: Implement .bdrv_get_info() Stefan Hajnoczi
2014-05-09 19:03 ` [Qemu-devel] [PULL 09/17] qemu-iotests: Test converting to streamOptimized from small cluster size Stefan Hajnoczi
2014-05-09 19:03 ` [Qemu-devel] [PULL 10/17] block: Fix open flags with BDRV_O_SNAPSHOT Stefan Hajnoczi
2014-05-09 19:03 ` [Qemu-devel] [PULL 11/17] vl.c: remove init_clocks call from main Stefan Hajnoczi
2014-05-09 19:03 ` [Qemu-devel] [PULL 12/17] gluster: Correctly propagate errors when volume isn't accessible Stefan Hajnoczi
2014-05-12 16:07 ` Eric Blake
2014-05-14 12:36 ` Stefan Hajnoczi
2014-05-14 12:52 ` Peter Krempa
2014-05-09 19:03 ` [Qemu-devel] [PULL 13/17] block/raw-posix: Try both FIEMAP and SEEK_HOLE Stefan Hajnoczi
2014-05-09 19:03 ` [Qemu-devel] [PULL 14/17] block: qemu-iotests - add common.qemu, for bash-controlled qemu tests Stefan Hajnoczi
2014-05-09 19:03 ` [Qemu-devel] [PULL 15/17] block: qemu-iotests - update 085 to use common.qemu Stefan Hajnoczi
2014-05-09 19:03 ` [Qemu-devel] [PULL 16/17] block: qemu-iotests - test for live migration Stefan Hajnoczi
2014-05-09 19:03 ` [Qemu-devel] [PULL 17/17] glib: fix g_poll early timeout on windows Stefan Hajnoczi
2014-05-13 10:32 ` [Qemu-devel] [PULL 00/17] Block patches Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1399662217-31148-8-git-send-email-stefanha@redhat.com \
--to=stefanha@redhat.com \
--cc=famz@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).