From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34790) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wirxh-0006Lb-Hk for qemu-devel@nongnu.org; Fri, 09 May 2014 17:04:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wirxb-0005cP-Fa for qemu-devel@nongnu.org; Fri, 09 May 2014 17:04:09 -0400 Received: from mail-ee0-x230.google.com ([2a00:1450:4013:c00::230]:39620) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wirxb-0005cK-8n for qemu-devel@nongnu.org; Fri, 09 May 2014 17:04:03 -0400 Received: by mail-ee0-f48.google.com with SMTP id e49so2981821eek.35 for ; Fri, 09 May 2014 14:04:02 -0700 (PDT) Sender: Paolo Bonzini From: Paolo Bonzini Date: Fri, 9 May 2014 23:03:40 +0200 Message-Id: <1399669424-29676-7-git-send-email-pbonzini@redhat.com> In-Reply-To: <1399669424-29676-1-git-send-email-pbonzini@redhat.com> References: <1399669424-29676-1-git-send-email-pbonzini@redhat.com> Subject: [Qemu-devel] [PULL 06/10] Makefile: use $(INSTALL_LIB) for modules not $(INSTALL_PROG) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Fam Zheng , mjt@tls.msk.ru From: Michael Tokarev We have $(INSTALL_LIB) which is the same as $(INSTALL_PROG) but uses correct permissions. Loadable objects (modules) are like shared libraries, not like programs. Signed-off-by: Michael Tokarev Cc: Fam Zheng Cc: Paolo Bonzini Signed-off-by: Paolo Bonzini --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 23ca444..12ea464 100644 --- a/Makefile +++ b/Makefile @@ -381,7 +381,7 @@ ifneq ($(CONFIG_MODULES),) $(INSTALL_DIR) "$(DESTDIR)$(qemu_moddir)" for s in $(modules-m:.mo=$(DSOSUF)); do \ t="$(DESTDIR)$(qemu_moddir)/$$(echo $$s | tr / -)"; \ - $(INSTALL_PROG) $$s "$$t"; \ + $(INSTALL_LIB) $$s "$$t"; \ test -z "$(STRIP)" || $(STRIP) "$$t"; \ done endif -- 1.8.3.1