qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Fam Zheng <famz@redhat.com>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, jcody@redhat.com, hbrock@redhat.com,
	rjones@redhat.com, armbru@redhat.com, imain@redhat.com,
	stefanha@redhat.com, pbonzini@redhat.com
Subject: [Qemu-devel] [PATCH v19 13/16] block: Allow backup on referenced named BlockDriverState
Date: Mon, 12 May 2014 09:35:52 +0800	[thread overview]
Message-ID: <1399858555-9672-14-git-send-email-famz@redhat.com> (raw)
In-Reply-To: <1399858555-9672-1-git-send-email-famz@redhat.com>

Drive backup is a read only operation on source bs. We want to allow
this specific case to enable image-fleecing. Note that when
image-fleecing job starts, the job still add its blocker to source bs,
and any other operation on it will be blocked by that.

Signed-off-by: Fam Zheng <famz@redhat.com>
---
 block.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/block.c b/block.c
index ab64027..b84b24e 100644
--- a/block.c
+++ b/block.c
@@ -1122,6 +1122,8 @@ void bdrv_set_backing_hd(BlockDriverState *bs, BlockDriverState *backing_hd)
     /* Otherwise we won't be able to commit due to check in bdrv_commit */
     bdrv_op_unblock(bs->backing_hd, BLOCK_OP_TYPE_COMMIT,
                     bs->backing_blocker);
+    bdrv_op_unblock(bs->backing_hd, BLOCK_OP_TYPE_BACKUP_SOURCE,
+                    bs->backing_blocker);
 out:
     bdrv_refresh_limits(bs);
 }
-- 
1.9.2

  parent reply	other threads:[~2014-05-12  1:36 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-12  1:35 [Qemu-devel] [PATCH v19 00/16] Drop in_use from BlockDriverState and enable point-in-time snapshot exporting over NBD Fam Zheng
2014-05-12  1:35 ` [Qemu-devel] [PATCH v19 01/16] vmdk: Optimize cluster allocation Fam Zheng
2014-05-14 14:00   ` Fam Zheng
2014-05-12  1:35 ` [Qemu-devel] [PATCH v19 02/16] block: Add BlockOpType enum Fam Zheng
2014-05-19 13:55   ` Markus Armbruster
2014-05-19 15:53   ` Eric Blake
2014-05-19 16:15     ` Markus Armbruster
2014-05-20  3:09       ` Fam Zheng
2014-05-12  1:35 ` [Qemu-devel] [PATCH v19 03/16] block: Introduce op_blockers to BlockDriverState Fam Zheng
2014-05-19 14:10   ` Markus Armbruster
2014-05-19 14:37     ` Kevin Wolf
2014-05-19 15:37       ` Jeff Cody
2014-05-20 11:43         ` Markus Armbruster
2014-05-12  1:35 ` [Qemu-devel] [PATCH v19 04/16] block: Replace in_use with operation blocker Fam Zheng
2014-05-19 14:28   ` Markus Armbruster
2014-05-20  3:26     ` Fam Zheng
2014-05-12  1:35 ` [Qemu-devel] [PATCH v19 05/16] block: Move op_blocker check from block_job_create to its caller Fam Zheng
2014-05-12  1:35 ` [Qemu-devel] [PATCH v19 06/16] block: Add bdrv_set_backing_hd() Fam Zheng
2014-05-12  1:35 ` [Qemu-devel] [PATCH v19 07/16] block: Add backing_blocker in BlockDriverState Fam Zheng
2014-05-19 19:35   ` Eric Blake
2014-05-19 20:23     ` Markus Armbruster
2014-05-20  3:39       ` Fam Zheng
2014-05-12  1:35 ` [Qemu-devel] [PATCH v19 08/16] block: Parse "backing" option to reference existing BDS Fam Zheng
2014-05-12  1:35 ` [Qemu-devel] [PATCH v19 09/16] block: Support dropping active in bdrv_drop_intermediate Fam Zheng
2014-05-19 19:38   ` Eric Blake
2014-05-20  3:53     ` Fam Zheng
2014-05-12  1:35 ` [Qemu-devel] [PATCH v19 10/16] stream: Use bdrv_drop_intermediate and drop close_unused_images Fam Zheng
2014-05-12  1:35 ` [Qemu-devel] [PATCH v19 11/16] commit: Use bdrv_drop_intermediate Fam Zheng
2014-05-12  1:35 ` [Qemu-devel] [PATCH v19 12/16] qmp: Add command 'blockdev-backup' Fam Zheng
2014-05-12  1:35 ` Fam Zheng [this message]
2014-05-12  1:35 ` [Qemu-devel] [PATCH v19 14/16] block: Add blockdev-backup to transaction Fam Zheng
2014-05-12  1:35 ` [Qemu-devel] [PATCH v19 15/16] qemu-iotests: Test blockdev-backup in 055 Fam Zheng
2014-05-19 19:46   ` Eric Blake
2014-05-20  3:56     ` Fam Zheng
2014-05-12  1:35 ` [Qemu-devel] [PATCH v19 16/16] qemu-iotests: Image fleecing test case 089 Fam Zheng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1399858555-9672-14-git-send-email-famz@redhat.com \
    --to=famz@redhat.com \
    --cc=armbru@redhat.com \
    --cc=hbrock@redhat.com \
    --cc=imain@redhat.com \
    --cc=jcody@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=rjones@redhat.com \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).