qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Marc Marí" <marc.mari.barcelo@gmail.com>
To: qemu-devel@nongnu.org
Cc: "Marc Marí" <marc.mari.barcelo@gmail.com>,
	"Stefan Hajnoczi" <stefanha@gmail.com>,
	"Peter Crosthwaite" <peter.crosthwaite@xilinx.com>,
	"Andreas Färber" <afaerber@suse.de>
Subject: [Qemu-devel] [PATCH v2 04/16] highbank: Convert conditional compilation of debug printfs to regular ifs
Date: Tue, 13 May 2014 09:02:40 +0200	[thread overview]
Message-ID: <1399964572-5376-5-git-send-email-marc.mari.barcelo@gmail.com> (raw)
In-Reply-To: <1399964572-5376-1-git-send-email-marc.mari.barcelo@gmail.com>

Modify debug macros to have the same format through the codebase and use regular
ifs instead of ifdef.

As the debug printf is always put in code, some casting had to be added to avoid
warnings treated as errors at compile time.

Signed-off-by: Marc Marí <marc.mari.barcelo@gmail.com>
---
 hw/net/xgmac.c |   10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/hw/net/xgmac.c b/hw/net/xgmac.c
index 88349ac..734c2e5 100644
--- a/hw/net/xgmac.c
+++ b/hw/net/xgmac.c
@@ -30,14 +30,16 @@
 #include "net/net.h"
 #include "net/checksum.h"
 
+//#define DEBUG_XGMAC
+
 #ifdef DEBUG_XGMAC
-#define DEBUGF_BRK(message, args...) do { \
-                                         fprintf(stderr, (message), ## args); \
-                                     } while (0)
+#define DEBUG_XGMAC_ENABLED 1
 #else
-#define DEBUGF_BRK(message, args...) do { } while (0)
+#define DEBUG_XGMAC_ENABLED 0
 #endif
 
+#define DEBUGF_BRK(message, args...) QEMU_DPRINTF(DEBUG_XGMAC_ENABLED, "xgmag", message, ## args)
+
 #define XGMAC_CONTROL           0x00000000   /* MAC Configuration */
 #define XGMAC_FRAME_FILTER      0x00000001   /* MAC Frame Filter */
 #define XGMAC_FLOW_CTRL         0x00000006   /* MAC Flow Control */
-- 
1.7.10.4

  parent reply	other threads:[~2014-05-13  7:04 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-13  7:02 [Qemu-devel] [PATCH v2 00/16] Convert conditional compilation of debug printfs Marc Marí
2014-05-13  7:02 ` [Qemu-devel] [PATCH v2 01/16] x86: Convert conditional compilation of debug printfs to regular ifs Marc Marí
2014-05-13  7:38   ` Andreas Färber
2014-05-13 15:15   ` Eric Blake
     [not found]   ` <53722E62.8000304@redhat.com>
2014-05-15  9:56     ` Marc Marí
2014-05-13  7:02 ` [Qemu-devel] [PATCH v2 02/16] s390: " Marc Marí
2014-05-13  9:04   ` Cornelia Huck
2014-05-13 14:45   ` Eric Blake
2014-05-13  7:02 ` [Qemu-devel] [PATCH v2 03/16] scsi: " Marc Marí
2014-05-13  7:02 ` Marc Marí [this message]
2014-05-13 10:06   ` [Qemu-devel] [PATCH v2 04/16] highbank: " Marc Marí
2014-05-13  7:02 ` [Qemu-devel] [PATCH v2 05/16] xilinx: " Marc Marí
2014-05-13  9:59   ` Marc Marí
2014-05-13  7:02 ` [Qemu-devel] [PATCH v2 06/16] spapr: " Marc Marí
2014-05-13  7:18   ` [Qemu-devel] [Qemu-ppc] " Alexander Graf
2014-05-13  7:02 ` [Qemu-devel] [PATCH v2 07/16] stellaris: " Marc Marí
2014-05-13 15:05   ` Eric Blake
2014-05-13  7:02 ` [Qemu-devel] [PATCH v2 08/16] tpm: " Marc Marí
2014-05-13  9:39   ` Marc Marí
2014-05-13  7:02 ` [Qemu-devel] [PATCH v2 09/16] i82374: " Marc Marí
2014-05-13  9:20   ` Marc Marí
2014-05-13  7:02 ` [Qemu-devel] [PATCH v2 10/16] i8257: " Marc Marí
2014-05-13  7:02 ` [Qemu-devel] [PATCH v2 11/16] rc4030: " Marc Marí
2014-05-13  9:16   ` Marc Marí
2014-05-13  7:02 ` [Qemu-devel] [PATCH v2 12/16] sd: " Marc Marí
2014-05-13  7:02 ` [Qemu-devel] [PATCH v2 13/16] isa: " Marc Marí
2014-05-13  7:02 ` [Qemu-devel] [PATCH v2 14/16] lan9118: " Marc Marí
2014-05-13  7:02 ` [Qemu-devel] [PATCH v2 15/16] pci-host: " Marc Marí
2014-05-13  9:13   ` Marc Marí
2014-05-13  7:02 ` [Qemu-devel] [PATCH v2 16/16] common: " Marc Marí
2014-05-13  9:05   ` Cornelia Huck
2014-05-13 15:21   ` Eric Blake

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1399964572-5376-5-git-send-email-marc.mari.barcelo@gmail.com \
    --to=marc.mari.barcelo@gmail.com \
    --cc=afaerber@suse.de \
    --cc=peter.crosthwaite@xilinx.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).