From: Gerd Hoffmann <kraxel@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: qemu-devel@nongnu.org, dgilbert@redhat.com
Subject: Re: [Qemu-devel] [PATCH] usb: fix up post load checks
Date: Tue, 13 May 2014 11:49:32 +0200 [thread overview]
Message-ID: <1399974572.7118.52.camel@nilsson.home.kraxel.org> (raw)
In-Reply-To: <20140513090507.GA29760@redhat.com>
Hi,
> And SETUP_STATE_PARAM?
Shortcut for small control transfers on xhci. Doesn't go through the
idle -> setup -> data -> ack state engine.
security-wise: you can't go from 'param' to 'data' without 'setup'
inbetween. beside that index should still be zero at the point where
len is modified (simliar to the other place in setup state).
side note: changing len should not happen in normal operation, only with
a malicious / buggy guest. It happens in case the guest claims the data
transfer is larger than the buffer supplied by the guest.
cheers,
Gerd
next prev parent reply other threads:[~2014-05-13 9:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-12 12:16 [Qemu-devel] [PATCH] usb: fix up post load checks Michael S. Tsirkin
2014-05-13 3:02 ` Gonglei (Arei)
2014-05-13 6:49 ` Gerd Hoffmann
2014-05-13 7:50 ` Gerd Hoffmann
2014-05-13 8:32 ` Michael S. Tsirkin
2014-05-13 8:44 ` Gerd Hoffmann
2014-05-13 9:05 ` Michael S. Tsirkin
2014-05-13 9:49 ` Gerd Hoffmann [this message]
2014-05-14 13:16 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1399974572.7118.52.camel@nilsson.home.kraxel.org \
--to=kraxel@redhat.com \
--cc=dgilbert@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).