From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: BALATON Zoltan <balaton@eik.bme.hu>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
qemu-ppc@nongnu.org, qemu-devel@nongnu.org,
David Gibson <david@gibson.dropbear.id.au>
Subject: Re: [PATCH 07/14] hw/ppc/Kconfig: Let the Sam460ex board use the PowerPC 405 devices
Date: Wed, 1 Jan 2020 16:37:36 +0100 [thread overview]
Message-ID: <13a08462-759a-32ab-2628-432dfb9fa47a@redhat.com> (raw)
In-Reply-To: <alpine.BSF.2.21.99999.352.2001011223290.5612@zero.eik.bme.hu>
On 1/1/20 12:29 PM, BALATON Zoltan wrote:
> On Tue, 31 Dec 2019, Philippe Mathieu-Daudé wrote:
>> When configured with --without-default-devices, the build fails:
>>
>> LINK ppc-softmmu/qemu-system-ppc
>> /usr/bin/ld: hw/ppc/sam460ex.o: in function `sam460ex_init':
>> hw/ppc/sam460ex.c:313: undefined reference to `ppc4xx_plb_init'
>> /usr/bin/ld: hw/ppc/sam460ex.c:353: undefined reference to
>> `ppc405_ebc_init'
>> collect2: error: ld returned 1 exit status
>> make[1]: *** [Makefile:206: qemu-system-ppc] Error 1
>>
>> Fix by selecting the PPC405 config.
>>
>> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>
> Reviewed-by: BALATON Zoltan <balaton@eik.bme.hu>
>
> (The 405 and 440 devices are currently entangled by both using similar
> parts and maybe not all of them are in 4xx yet. Because of this I'm not
> sure if it's worth having separate configure options for these or just
> have a common PPC4XX option for now until these are cleaned up to
> separate them.)
You are correct. Using a config.mak limited to CONFIG_SAM460EX=y also
pulls the 440-based machines in.
Building this series with 'make ppc-softmmu/all':
$ ppc-softmmu/qemu-system-ppc -M help
Supported machines are:
bamboo bamboo
none empty machine
ref405ep ref405ep
sam460ex aCube Sam460ex
taihu taihu
Thanks for the review!
>
> Regards,
> BALATON Zoltan
>
>> ---
>> hw/ppc/Kconfig | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/hw/ppc/Kconfig b/hw/ppc/Kconfig
>> index 0cd8d4053e..004b7d5ad5 100644
>> --- a/hw/ppc/Kconfig
>> +++ b/hw/ppc/Kconfig
>> @@ -50,6 +50,7 @@ config PPC4XX
>>
>> config SAM460EX
>> bool
>> + select PPC405
>> select PFLASH_CFI01
>> select IDE_SII3112
>> select M41T80
>>
next prev parent reply other threads:[~2020-01-01 15:37 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-31 18:32 [PATCH 00/14] hw: Fix various --without-default-devices issues Philippe Mathieu-Daudé
2019-12-31 18:32 ` [PATCH 01/14] hw/usb/redirect: Do not link 'usb-redir' device when USB not enabled Philippe Mathieu-Daudé
2020-01-07 12:24 ` Thomas Huth
2019-12-31 18:32 ` [PATCH 02/14] hw/intc/i8259: Fix Kconfig dependency on ISA bus Philippe Mathieu-Daudé
2020-01-07 12:28 ` Thomas Huth
2019-12-31 18:32 ` [PATCH 03/14] hw/i386/Kconfig: Let the MicroVM machine select the SERIAL_ISA config Philippe Mathieu-Daudé
2020-01-07 10:00 ` Paolo Bonzini
2020-01-07 10:06 ` Philippe Mathieu-Daudé
2019-12-31 18:32 ` [PATCH 04/14] hw/i386: Restrict fw_cfg to the PC machines Philippe Mathieu-Daudé
2020-01-07 10:00 ` Paolo Bonzini
2020-01-07 10:01 ` Paolo Bonzini
2020-01-07 10:07 ` Philippe Mathieu-Daudé
2020-01-07 10:16 ` Michael S. Tsirkin
2020-01-07 12:22 ` Paolo Bonzini
2019-12-31 18:32 ` [PATCH 05/14] hw/i2c/Kconfig: Add an entry for the SMBus Philippe Mathieu-Daudé
2019-12-31 19:16 ` Corey Minyard
2020-01-01 10:25 ` Philippe Mathieu-Daudé
2020-01-01 16:15 ` Corey Minyard
2020-01-01 16:21 ` Philippe Mathieu-Daudé
2019-12-31 18:32 ` [PATCH 06/14] hw/ppc/Kconfig: Restrict the MPC I2C controller to e500-based platforms Philippe Mathieu-Daudé
2020-01-02 2:03 ` David Gibson
2019-12-31 18:32 ` [PATCH 07/14] hw/ppc/Kconfig: Let the Sam460ex board use the PowerPC 405 devices Philippe Mathieu-Daudé
2020-01-01 11:29 ` BALATON Zoltan
2020-01-01 15:37 ` Philippe Mathieu-Daudé [this message]
2020-01-02 2:03 ` David Gibson
2019-12-31 18:32 ` [PATCH 08/14] hw/ppc/Kconfig: Let the Xilinx Virtex5 ML507 use the PPC-440 devices Philippe Mathieu-Daudé
2020-01-02 2:04 ` David Gibson
2019-12-31 18:32 ` [PATCH 09/14] hw/ppc/Makefile: Simplify the sPAPR PCI objects rule Philippe Mathieu-Daudé
2020-01-02 2:05 ` David Gibson
2019-12-31 18:32 ` [PATCH 10/14] hw/ppc/Kconfig: Only select fw_cfg with machines using OpenBIOS Philippe Mathieu-Daudé
2020-01-02 2:05 ` David Gibson
2019-12-31 18:32 ` [PATCH 11/14] hw/ppc/Kconfig: Only select FDT helper for machines using it Philippe Mathieu-Daudé
2020-01-02 2:06 ` David Gibson
2019-12-31 18:32 ` [PATCH 12/14] hw/nvram/Kconfig: Add an entry for the NMC93xx EEPROM Philippe Mathieu-Daudé
2020-01-01 10:31 ` Philippe Mathieu-Daudé
2020-01-07 10:08 ` Paolo Bonzini
2019-12-31 18:32 ` [PATCH 13/14] hw/nvram/Kconfig: Restrict CHRP NVRAM to machines using OpenBIOS or SLOF Philippe Mathieu-Daudé
2020-01-02 2:07 ` David Gibson
2019-12-31 18:32 ` [RFC PATCH 14/14] hw/intc/Kconfig: Let APIC select IOAPIC Philippe Mathieu-Daudé
2020-01-07 9:58 ` Paolo Bonzini
2020-01-07 10:11 ` [PATCH 00/14] hw: Fix various --without-default-devices issues Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=13a08462-759a-32ab-2628-432dfb9fa47a@redhat.com \
--to=philmd@redhat.com \
--cc=balaton@eik.bme.hu \
--cc=david@gibson.dropbear.id.au \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).