From: Richard Henderson <richard.henderson@linaro.org>
To: Alexander Graf <agraf@csgraf.de>, Cameron Esfahani <dirty@apple.com>
Cc: "Paolo Bonzini" <pbonzini@redhat.com>,
"Roman Bolshakov" <r.bolshakov@yadro.com>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
qemu-devel@nongnu.org, kettenis@openbsd.org
Subject: Re: [PATCH v2] hvf: arm: Ignore cache operations on MMIO
Date: Tue, 26 Oct 2021 09:10:46 -0700 [thread overview]
Message-ID: <13a13852-4fb4-a0f8-6740-354c8054aed1@linaro.org> (raw)
In-Reply-To: <20211026071241.74889-1-agraf@csgraf.de>
On 10/26/21 12:12 AM, Alexander Graf wrote:
> + if (cm) {
> + /* We don't cache MMIO regions */
> + advance_pc = true;
> + break;
> + }
> +
> assert(isv);
The assert should come first. If the "iss valid" bit is not set, then nothing else in the
word is defined.
Otherwise,
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
next prev parent reply other threads:[~2021-10-26 16:21 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-26 7:12 [PATCH v2] hvf: arm: Ignore cache operations on MMIO Alexander Graf
2021-10-26 8:57 ` Philippe Mathieu-Daudé
2021-10-26 9:34 ` Mark Kettenis
2021-10-26 16:10 ` Richard Henderson [this message]
2021-10-26 16:38 ` Alexander Graf
2021-10-26 17:39 ` Richard Henderson
2021-11-01 18:03 ` Peter Maydell
2021-11-01 17:55 ` Peter Maydell
2021-11-01 18:04 ` Richard Henderson
2021-11-01 18:02 ` Richard Henderson
2021-11-01 19:35 ` Peter Maydell
2021-11-02 10:01 ` Richard Henderson
2021-11-02 10:42 ` Peter Maydell
2021-11-02 11:15 ` Richard Henderson
2021-11-02 18:19 ` Richard Henderson
2021-11-01 18:19 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=13a13852-4fb4-a0f8-6740-354c8054aed1@linaro.org \
--to=richard.henderson@linaro.org \
--cc=agraf@csgraf.de \
--cc=dirty@apple.com \
--cc=f4bug@amsat.org \
--cc=kettenis@openbsd.org \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=r.bolshakov@yadro.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).