From: Richard Henderson <richard.henderson@linaro.org>
To: Alistair Francis <alistair23@gmail.com>
Cc: "open list:RISC-V" <qemu-riscv@nongnu.org>,
Palmer Dabbelt <palmer@dabbelt.com>,
Bin Meng <bmeng.cn@gmail.com>,
Alistair Francis <alistair.francis@wdc.com>,
"qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>
Subject: Re: [PATCH v3 08/10] target/riscv: Consolidate RV32/64 32-bit instructions
Date: Sun, 25 Apr 2021 16:53:14 -0700 [thread overview]
Message-ID: <13a345dc-4143-339e-1c7c-5f9a1cd7eac3@linaro.org> (raw)
In-Reply-To: <CAKmqyKP5tuddPKiSOt1V6YyDjV+9VAM2vU=F1BvLgwXWHm=VKg@mail.gmail.com>
On 4/25/21 3:58 PM, Alistair Francis wrote:
> On Sun, Apr 25, 2021 at 3:08 AM Richard Henderson
> <richard.henderson@linaro.org> wrote:
>>
>> On 4/23/21 8:34 PM, Alistair Francis wrote:
>>> --- a/target/riscv/translate.c
>>> +++ b/target/riscv/translate.c
>>> @@ -74,8 +74,6 @@ static inline bool has_ext(DisasContext *ctx, uint32_t ext)
>>>
>>> #ifdef TARGET_RISCV32
>>> # define is_32bit(ctx) true
>>> -#elif defined(CONFIG_USER_ONLY)
>>> -# define is_32bit(ctx) false
>>> #else
>>> static inline bool is_32bit(DisasContext *ctx)
>>> {
>>
>> Rebase error?
>
> This is required to avoid warnings/errors before this commit as
> `is_32bit()` isn't called until this patch.
If !defined(TARGET_RISCV32) && defined(CONFIG_USER_ONLY), then is_32bit *is*
false. This isn't system mode and it can't be changed.
r~
next prev parent reply other threads:[~2021-04-25 23:54 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-24 3:28 [PATCH v3 00/10] RISC-V: Steps towards running 32-bit guests on Alistair Francis
2021-04-24 3:28 ` [PATCH v3 01/10] target/riscv: Remove the hardcoded RVXLEN macro Alistair Francis
2021-04-24 3:29 ` [PATCH v3 02/10] target/riscv: Remove the hardcoded SSTATUS_SD macro Alistair Francis
2021-04-24 3:31 ` [PATCH v3 03/10] target/riscv: Remove the hardcoded HGATP_MODE macro Alistair Francis
2021-04-24 3:33 ` [PATCH v3 04/10] target/riscv: Remove the hardcoded MSTATUS_SD macro Alistair Francis
2021-04-24 3:33 ` [PATCH v3 05/10] target/riscv: Remove the hardcoded SATP_MODE macro Alistair Francis
2021-04-24 3:33 ` [PATCH v3 06/10] target/riscv: Remove the unused HSTATUS_WPRI macro Alistair Francis
2021-04-24 3:34 ` [PATCH v3 07/10] target/riscv: Remove an unused CASE_OP_32_64 macro Alistair Francis
2021-04-24 3:34 ` [PATCH v3 08/10] target/riscv: Consolidate RV32/64 32-bit instructions Alistair Francis
2021-04-24 17:08 ` Richard Henderson
2021-04-25 22:58 ` Alistair Francis
2021-04-25 23:53 ` Richard Henderson [this message]
2021-04-26 5:33 ` Alistair Francis
2021-04-24 3:34 ` [PATCH v3 09/10] target/riscv: Consolidate RV32/64 16-bit instructions Alistair Francis
2021-04-24 3:34 ` [PATCH v3 10/10] target/riscv: Fix the RV64H decode comment Alistair Francis
2021-04-24 17:14 ` Richard Henderson
2021-04-25 22:58 ` Alistair Francis
2021-04-25 22:58 ` [PATCH v3 00/10] RISC-V: Steps towards running 32-bit guests on Alistair Francis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=13a345dc-4143-339e-1c7c-5f9a1cd7eac3@linaro.org \
--to=richard.henderson@linaro.org \
--cc=alistair.francis@wdc.com \
--cc=alistair23@gmail.com \
--cc=bmeng.cn@gmail.com \
--cc=palmer@dabbelt.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-riscv@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).