From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35652) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c9YTW-0000Of-SK for qemu-devel@nongnu.org; Wed, 23 Nov 2016 09:24:40 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c9YTR-0001lN-V2 for qemu-devel@nongnu.org; Wed, 23 Nov 2016 09:24:38 -0500 Received: from mx1.redhat.com ([209.132.183.28]:37822) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1c9YTR-0001kg-Mg for qemu-devel@nongnu.org; Wed, 23 Nov 2016 09:24:33 -0500 References: <1479874588-1969-1-git-send-email-eblake@redhat.com> <1479874588-1969-4-git-send-email-eblake@redhat.com> <898038411.1379870.1479893131197.JavaMail.zimbra@redhat.com> <87h96yp9ez.fsf@dusky.pond.sub.org> From: Eric Blake Message-ID: <13a6a125-3968-26cf-4f3e-c51f4df8cf61@redhat.com> Date: Wed, 23 Nov 2016 08:24:31 -0600 MIME-Version: 1.0 In-Reply-To: <87h96yp9ez.fsf@dusky.pond.sub.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="HIu3Decx9dES15qUeRRQ6906v54XaHiNx" Subject: Re: [Qemu-devel] [PATCH 3/3] qapi: Drop support for qobject_from_jsonf("%"PRId64) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: Paolo Bonzini , Michael Roth , programmingkidx@gmail.com, qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --HIu3Decx9dES15qUeRRQ6906v54XaHiNx From: Eric Blake To: Markus Armbruster Cc: Paolo Bonzini , Michael Roth , programmingkidx@gmail.com, qemu-devel@nongnu.org Message-ID: <13a6a125-3968-26cf-4f3e-c51f4df8cf61@redhat.com> Subject: Re: [Qemu-devel] [PATCH 3/3] qapi: Drop support for qobject_from_jsonf("%"PRId64) References: <1479874588-1969-1-git-send-email-eblake@redhat.com> <1479874588-1969-4-git-send-email-eblake@redhat.com> <898038411.1379870.1479893131197.JavaMail.zimbra@redhat.com> <87h96yp9ez.fsf@dusky.pond.sub.org> In-Reply-To: <87h96yp9ez.fsf@dusky.pond.sub.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 11/23/2016 08:17 AM, Markus Armbruster wrote: >=20 > The first two patches are bug fixes, and as such they should be > considered for 2.8. >=20 > This patch doesn't fix anything, and it might conceivably break > something. Too late for 2.8. Ah, but it DOES fix check-qjson on Mac OS. As mentioned to Paolo, I'm splitting this into two parts for the v2 series (the first part to fix testsuite failures on Mac OS which is still 2.8 material, the second to rip out %I64d which becomes more of 2.9 material). >> My other argument is that I _do_ intend to rip out ALL of the dynamic >> JSON support, at which point we no longer have %d, let along %lld. >> Until you see that followup series and decide whether it was too >> invasive for 2.9, it's hard to say that we are throwing out anything >> useful in this short-term fix for 2.8. So I guess that gives me a >> reason to hurry up and finish my work on that series to post it today >> before I take a long holiday weekend. >=20 > If we rip out _jsonf() in 2.9, then ripping out currently unused parts > of it in 2.8 during hard freeze is needless churn at a rather > inconvenient time. >=20 > If we decice not to rip it out, it may well have to be reverted. >=20 > I don't think there's a need to hurry, as this patch isn't appropriate > for 2.8 anyway, so there's no reason to quickly decide what to do with > the followup series now. Fair enough. v2 coming soon. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --HIu3Decx9dES15qUeRRQ6906v54XaHiNx Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJYNaafAAoJEKeha0olJ0Nqgs0H/R4PVMPAW3ZFgHGUM+qpRzG1 OsXJtRY3ifUuJ8JpjYgWWtGC2HtwuWhnplvWdZco5MBHqrjjQPs8tYG4jDPQ09RZ ImkU/ITsSNXMNpnb60zK+jHA12iFoEC4HbpvzlK3QeupbMqRj5M697alMNqUjKGG /dLutAb0lUPGo/dLvK/uTTUGMHLddePJwNdEL8vyAIJ3WoTEVEtTRHMQbed1IS59 e+IBkuPnmNLJHW/ANYqIV0Crr73SUzmbrwSXc6ghoAA6sxh5xABFK0M+/ytRzAzL 9OMFHOsTrs2EQz+Ddb3gPDCV7bqRXa1xSkvbWX5JIOQWWKpjC7sPlaXWJhzMV3o= =x7Fe -----END PGP SIGNATURE----- --HIu3Decx9dES15qUeRRQ6906v54XaHiNx--