From: Paolo Bonzini <pbonzini@redhat.com>
To: Chris Hofstaedtler <chris@hofstaedtler.name>, qemu-devel@nongnu.org
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>
Subject: Re: [PATCH v2] meson: fix Cocoa option in summary
Date: Thu, 7 Jan 2021 12:36:30 +0100 [thread overview]
Message-ID: <13aacba5-b1b1-f2bf-22db-3eb88be26447@redhat.com> (raw)
In-Reply-To: <20201230221623.60423-1-chris@hofstaedtler.name>
On 30/12/20 23:16, Chris Hofstaedtler wrote:
> Cocoa support was always shown as "no", even it if was enabled.
>
> Fixes: b4e312e953b ("configure: move cocoa option to Meson")
> Cc: Paolo Bonzini <pbonzini@redhat.com>
> Cc: Peter Maydell <peter.maydell@linaro.org>
> Cc: Philippe Mathieu-Daudé <philmd@redhat.com>
> Signed-off-by: Chris Hofstaedtler <chris@hofstaedtler.name>
> ---
> meson.build | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meson.build b/meson.build
> index 372576f82c..1112ca8fc2 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -2082,7 +2082,7 @@ summary_info += {'strip binaries': get_option('strip')}
> summary_info += {'profiler': config_host.has_key('CONFIG_PROFILER')}
> summary_info += {'static build': config_host.has_key('CONFIG_STATIC')}
> if targetos == 'darwin'
> - summary_info += {'Cocoa support': config_host.has_key('CONFIG_COCOA')}
> + summary_info += {'Cocoa support': config_host_data.get('CONFIG_COCOA', false)}
> endif
> # TODO: add back version
> summary_info += {'SDL support': sdl.found()}
>
Queued, thanks.
Paolo
prev parent reply other threads:[~2021-01-07 11:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-30 22:16 [PATCH v2] meson: fix Cocoa option in summary Chris Hofstaedtler
2020-12-31 10:22 ` Philippe Mathieu-Daudé
2021-01-07 11:36 ` Paolo Bonzini
2021-01-07 11:36 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=13aacba5-b1b1-f2bf-22db-3eb88be26447@redhat.com \
--to=pbonzini@redhat.com \
--cc=chris@hofstaedtler.name \
--cc=peter.maydell@linaro.org \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).