* [PATCH v2] meson: fix Cocoa option in summary
@ 2020-12-30 22:16 Chris Hofstaedtler
2020-12-31 10:22 ` Philippe Mathieu-Daudé
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Chris Hofstaedtler @ 2020-12-30 22:16 UTC (permalink / raw)
To: qemu-devel
Cc: Paolo Bonzini, Philippe Mathieu-Daudé, Chris Hofstaedtler,
Peter Maydell
Cocoa support was always shown as "no", even it if was enabled.
Fixes: b4e312e953b ("configure: move cocoa option to Meson")
Cc: Paolo Bonzini <pbonzini@redhat.com>
Cc: Peter Maydell <peter.maydell@linaro.org>
Cc: Philippe Mathieu-Daudé <philmd@redhat.com>
Signed-off-by: Chris Hofstaedtler <chris@hofstaedtler.name>
---
meson.build | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/meson.build b/meson.build
index 372576f82c..1112ca8fc2 100644
--- a/meson.build
+++ b/meson.build
@@ -2082,7 +2082,7 @@ summary_info += {'strip binaries': get_option('strip')}
summary_info += {'profiler': config_host.has_key('CONFIG_PROFILER')}
summary_info += {'static build': config_host.has_key('CONFIG_STATIC')}
if targetos == 'darwin'
- summary_info += {'Cocoa support': config_host.has_key('CONFIG_COCOA')}
+ summary_info += {'Cocoa support': config_host_data.get('CONFIG_COCOA', false)}
endif
# TODO: add back version
summary_info += {'SDL support': sdl.found()}
--
2.29.2
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH v2] meson: fix Cocoa option in summary
2020-12-30 22:16 [PATCH v2] meson: fix Cocoa option in summary Chris Hofstaedtler
@ 2020-12-31 10:22 ` Philippe Mathieu-Daudé
2021-01-07 11:36 ` Paolo Bonzini
2021-01-07 11:36 ` Paolo Bonzini
2 siblings, 0 replies; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-12-31 10:22 UTC (permalink / raw)
To: Chris Hofstaedtler, qemu-devel; +Cc: Paolo Bonzini, Peter Maydell
On 12/30/20 11:16 PM, Chris Hofstaedtler wrote:
> Cocoa support was always shown as "no", even it if was enabled.
>
> Fixes: b4e312e953b ("configure: move cocoa option to Meson")
> Cc: Paolo Bonzini <pbonzini@redhat.com>
> Cc: Peter Maydell <peter.maydell@linaro.org>
> Cc: Philippe Mathieu-Daudé <philmd@redhat.com>
> Signed-off-by: Chris Hofstaedtler <chris@hofstaedtler.name>
> ---
> meson.build | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meson.build b/meson.build
> index 372576f82c..1112ca8fc2 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -2082,7 +2082,7 @@ summary_info += {'strip binaries': get_option('strip')}
> summary_info += {'profiler': config_host.has_key('CONFIG_PROFILER')}
> summary_info += {'static build': config_host.has_key('CONFIG_STATIC')}
> if targetos == 'darwin'
> - summary_info += {'Cocoa support': config_host.has_key('CONFIG_COCOA')}
> + summary_info += {'Cocoa support': config_host_data.get('CONFIG_COCOA', false)}
> endif
> # TODO: add back version
> summary_info += {'SDL support': sdl.found()}
>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH v2] meson: fix Cocoa option in summary
2020-12-30 22:16 [PATCH v2] meson: fix Cocoa option in summary Chris Hofstaedtler
2020-12-31 10:22 ` Philippe Mathieu-Daudé
@ 2021-01-07 11:36 ` Paolo Bonzini
2021-01-07 11:36 ` Paolo Bonzini
2 siblings, 0 replies; 4+ messages in thread
From: Paolo Bonzini @ 2021-01-07 11:36 UTC (permalink / raw)
To: Chris Hofstaedtler, qemu-devel; +Cc: Peter Maydell, Philippe Mathieu-Daudé
On 30/12/20 23:16, Chris Hofstaedtler wrote:
> Cocoa support was always shown as "no", even it if was enabled.
>
> Fixes: b4e312e953b ("configure: move cocoa option to Meson")
> Cc: Paolo Bonzini <pbonzini@redhat.com>
> Cc: Peter Maydell <peter.maydell@linaro.org>
> Cc: Philippe Mathieu-Daudé <philmd@redhat.com>
> Signed-off-by: Chris Hofstaedtler <chris@hofstaedtler.name>
> ---
> meson.build | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meson.build b/meson.build
> index 372576f82c..1112ca8fc2 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -2082,7 +2082,7 @@ summary_info += {'strip binaries': get_option('strip')}
> summary_info += {'profiler': config_host.has_key('CONFIG_PROFILER')}
> summary_info += {'static build': config_host.has_key('CONFIG_STATIC')}
> if targetos == 'darwin'
> - summary_info += {'Cocoa support': config_host.has_key('CONFIG_COCOA')}
> + summary_info += {'Cocoa support': config_host_data.get('CONFIG_COCOA', false)}
> endif
> # TODO: add back version
> summary_info += {'SDL support': sdl.found()}
>
Using config_host_data makes sense, however "cocoa.found()" is more
consistent with the surrounding code.
Paolo
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH v2] meson: fix Cocoa option in summary
2020-12-30 22:16 [PATCH v2] meson: fix Cocoa option in summary Chris Hofstaedtler
2020-12-31 10:22 ` Philippe Mathieu-Daudé
2021-01-07 11:36 ` Paolo Bonzini
@ 2021-01-07 11:36 ` Paolo Bonzini
2 siblings, 0 replies; 4+ messages in thread
From: Paolo Bonzini @ 2021-01-07 11:36 UTC (permalink / raw)
To: Chris Hofstaedtler, qemu-devel; +Cc: Peter Maydell, Philippe Mathieu-Daudé
On 30/12/20 23:16, Chris Hofstaedtler wrote:
> Cocoa support was always shown as "no", even it if was enabled.
>
> Fixes: b4e312e953b ("configure: move cocoa option to Meson")
> Cc: Paolo Bonzini <pbonzini@redhat.com>
> Cc: Peter Maydell <peter.maydell@linaro.org>
> Cc: Philippe Mathieu-Daudé <philmd@redhat.com>
> Signed-off-by: Chris Hofstaedtler <chris@hofstaedtler.name>
> ---
> meson.build | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meson.build b/meson.build
> index 372576f82c..1112ca8fc2 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -2082,7 +2082,7 @@ summary_info += {'strip binaries': get_option('strip')}
> summary_info += {'profiler': config_host.has_key('CONFIG_PROFILER')}
> summary_info += {'static build': config_host.has_key('CONFIG_STATIC')}
> if targetos == 'darwin'
> - summary_info += {'Cocoa support': config_host.has_key('CONFIG_COCOA')}
> + summary_info += {'Cocoa support': config_host_data.get('CONFIG_COCOA', false)}
> endif
> # TODO: add back version
> summary_info += {'SDL support': sdl.found()}
>
Queued, thanks.
Paolo
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-01-07 11:37 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-12-30 22:16 [PATCH v2] meson: fix Cocoa option in summary Chris Hofstaedtler
2020-12-31 10:22 ` Philippe Mathieu-Daudé
2021-01-07 11:36 ` Paolo Bonzini
2021-01-07 11:36 ` Paolo Bonzini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).