From: Thomas Huth <thuth@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Laurent Vivier <lvivier@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Juan Quintela <quintela@redhat.com>,
qemu-devel@nongnu.org,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>
Subject: Re: [PATCH] Revert "tests/migration: Reduce autoconverge initial bandwidth"
Date: Tue, 30 Jun 2020 16:44:20 +0200 [thread overview]
Message-ID: <13bf9c9a-32a5-61f9-c2c5-8df9bbba52bc@redhat.com> (raw)
In-Reply-To: <20200630104328-mutt-send-email-mst@kernel.org>
On 30/06/2020 16.43, Michael S. Tsirkin wrote:
> On Tue, Jun 30, 2020 at 03:20:04PM +0200, Thomas Huth wrote:
>> On 30/06/2020 15.07, Michael S. Tsirkin wrote:
>>> On Tue, Jun 23, 2020 at 10:57:02AM -0400, Michael S. Tsirkin wrote:
>>>> This reverts commit 6d1da867e65f ("tests/migration: Reduce autoconverge initial bandwidth")
>>>> since that change makes unit tests much slower for all developers, while it's not
>>>> a robust way to fix migration tests. Migration tests need to find
>>>> a more robust way to discover a reasonable bandwidth without slowing
>>>> things down for everyone.
>>>>
>>>> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
>>>
>>> What's the conclusion here? Should I merge this?
>>
>> Fine for me (from the s390x side). The test should not run with TCG in the
>> CI for s390x ... if it still does, we have to have another closer look at
>> the check there instead.
>>
>> Thomas
>
> ack pls?
Acked-by: Thomas Huth <thuth@redhat.com>
next prev parent reply other threads:[~2020-06-30 14:45 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-23 14:56 [PATCH] Revert "tests/migration: Reduce autoconverge initial bandwidth" Michael S. Tsirkin
2020-06-23 15:39 ` Philippe Mathieu-Daudé
2020-06-23 17:07 ` Thomas Huth
2020-06-23 17:35 ` Philippe Mathieu-Daudé
2020-06-23 20:59 ` Michael S. Tsirkin
2020-06-24 5:04 ` Thomas Huth
2020-06-24 10:21 ` Philippe Mathieu-Daudé
2020-06-24 16:26 ` Philippe Mathieu-Daudé
2020-06-25 5:35 ` Thomas Huth
2020-06-23 20:58 ` Michael S. Tsirkin
2020-06-24 15:53 ` Dr. David Alan Gilbert
2020-06-30 13:07 ` Michael S. Tsirkin
2020-06-30 13:20 ` Thomas Huth
2020-06-30 14:43 ` Michael S. Tsirkin
2020-06-30 14:44 ` Thomas Huth [this message]
2020-06-30 13:59 ` Dr. David Alan Gilbert
2020-06-30 14:43 ` Michael S. Tsirkin
2020-06-30 14:54 ` Dr. David Alan Gilbert
2020-06-30 14:55 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=13bf9c9a-32a5-61f9-c2c5-8df9bbba52bc@redhat.com \
--to=thuth@redhat.com \
--cc=dgilbert@redhat.com \
--cc=lvivier@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).