From: Richard Henderson <richard.henderson@linaro.org>
To: Andrew Jones <drjones@redhat.com>,
qemu-devel@nongnu.org, qemu-arm@nongnu.org
Cc: peter.maydell@linaro.org, alex.bennee@linaro.org,
Dave.Martin@arm.com, eric.auger@redhat.com
Subject: Re: [PATCH v3] target/arm/arch_dump: Add SVE notes
Date: Wed, 16 Oct 2019 11:47:11 -0700 [thread overview]
Message-ID: <13c4d99b-2e63-af31-1ce3-5f733c957d11@linaro.org> (raw)
In-Reply-To: <20191016163750.11751-1-drjones@redhat.com>
On 10/16/19 9:37 AM, Andrew Jones wrote:
> When dumping a guest with dump-guest-memory also dump the SVE
> registers if they are in use.
>
> Signed-off-by: Andrew Jones <drjones@redhat.com>
> ---
> v3:
> - Pulled sve_bswap64 out of kvm64.c and reused it here
> - Changed fpsr_offset and sve_size to only align to a
> 16 byte boundary from the note payload offset, not
> from the note head. Doing this makes it consistent
> with the documentation and what gcore does. Testing
> shows that the elf headers and gdb are still happy.
> - Added blank lines between functions
>
>
> include/elf.h | 2 +
> target/arm/arch_dump.c | 124 ++++++++++++++++++++++++++++++++++++++++-
> target/arm/cpu.h | 25 +++++++++
> target/arm/kvm64.c | 24 --------
> 4 files changed, 149 insertions(+), 26 deletions(-)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
prev parent reply other threads:[~2019-10-16 18:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-16 16:37 [PATCH v3] target/arm/arch_dump: Add SVE notes Andrew Jones
2019-10-16 18:47 ` Richard Henderson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=13c4d99b-2e63-af31-1ce3-5f733c957d11@linaro.org \
--to=richard.henderson@linaro.org \
--cc=Dave.Martin@arm.com \
--cc=alex.bennee@linaro.org \
--cc=drjones@redhat.com \
--cc=eric.auger@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).