From: Richard Henderson <richard.henderson@linaro.org>
To: "Christoph Muellner" <christoph.muellner@vrull.eu>,
qemu-riscv@nongnu.org, qemu-devel@nongnu.org,
"Alistair Francis" <alistair.francis@wdc.com>,
"Bin Meng" <bin.meng@windriver.com>,
"Philipp Tomsich" <philipp.tomsich@vrull.eu>,
"Heiko Stübner" <heiko.stuebner@vrull.eu>,
"Palmer Dabbelt" <palmer@dabbelt.com>,
"Nelson Chu" <nelson@rivosinc.com>,
"Kito Cheng" <kito.cheng@sifive.com>,
"Cooper Qu" <cooper.qu@linux.alibaba.com>,
"Lifang Xia" <lifang_xia@linux.alibaba.com>,
"Yunhai Shang" <yunhai@linux.alibaba.com>,
"Zhiwei Liu" <zhiwei_liu@linux.alibaba.com>
Subject: Re: [PATCH 10/11] RISC-V: Adding T-Head FMemIdx extension
Date: Thu, 8 Sep 2022 08:45:08 +0100 [thread overview]
Message-ID: <13c9f7be-d8b8-37aa-ee99-79056e11e30c@linaro.org> (raw)
In-Reply-To: <20220906122243.1243354-11-christoph.muellner@vrull.eu>
On 9/6/22 13:22, Christoph Muellner wrote:
> @@ -732,6 +733,7 @@ static int ex_rvc_shifti(DisasContext *ctx, int imm)
> #include "decode-xtheadbs.c.inc"
> #include "decode-xtheadcmo.c.inc"
> #include "decode-xtheadcondmov.c.inc"
> +#include "decode-xtheadfmemidx.c.inc"
> #include "decode-xtheadmac.c.inc"
> #include "decode-xtheadmemidx.c.inc"
> #include "decode-xtheadmempair.c.inc"
> @@ -1061,6 +1063,7 @@ static void decode_opc(CPURISCVState *env, DisasContext *ctx, uint16_t opcode)
> { has_xtheadbs_p, decode_xtheadbs },
> { has_xtheadcmo_p, decode_xtheadcmo },
> { has_xtheadcondmov_p, decode_xtheadcondmov },
> + { has_xtheadfmemidx_p, decode_xtheadfmemidx },
> { has_xtheadmac_p, decode_xtheadmac },
> { has_xtheadmemidx_p, decode_xtheadmemidx },
> { has_xtheadmempair_p, decode_xtheadmempair },
I think you should have a single decoder for all of the xthread extensions, and each
translate function should test for the individual extension. You know up-front that these
extensions do not conflict.
r~
next prev parent reply other threads:[~2022-09-08 7:47 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-06 12:22 [PATCH 00/11] Add support for the T-Head vendor extensions Christoph Muellner
2022-09-06 12:22 ` [PATCH 01/11] riscv: Add privilege level to DisasContext Christoph Muellner
2022-09-16 2:46 ` LIU Zhiwei
2022-09-16 6:00 ` Richard Henderson
2022-09-16 6:05 ` Richard Henderson
2022-09-16 6:21 ` LIU Zhiwei
2022-09-06 12:22 ` [PATCH 02/11] RISC-V: Adding T-Head CMO instructions Christoph Muellner
2022-09-16 2:47 ` LIU Zhiwei
2022-09-16 6:43 ` LIU Zhiwei
2022-09-16 7:59 ` Richard Henderson
2022-09-06 12:22 ` [PATCH 03/11] RISC-V: Adding T-Head SYNC instructions Christoph Muellner
2022-09-08 7:29 ` Richard Henderson
2022-09-09 17:21 ` Christoph Müllner
2022-12-12 9:12 ` LIU Zhiwei
2022-12-12 9:21 ` LIU Zhiwei
2022-09-06 12:22 ` [PATCH 04/11] RISC-V: Adding T-Head Bitmanip instructions Christoph Muellner
2022-09-16 9:12 ` LIU Zhiwei
2022-09-06 12:22 ` [PATCH 05/11] RISC-V: Adding T-Head CondMov instructions Christoph Muellner
2022-09-06 12:22 ` [PATCH 06/11] RISC-V: Adding T-Head multiply-accumulate instructions Christoph Muellner
2022-09-06 12:22 ` [PATCH 07/11] RISC-V: Adding T-Head XMAE support Christoph Muellner
2022-09-06 12:22 ` [PATCH 08/11] RISC-V: Adding T-Head MemPair extension Christoph Muellner
2022-09-06 12:22 ` [PATCH 09/11] RISC-V: Adding T-Head MemIdx extension Christoph Muellner
2022-09-06 12:22 ` [PATCH 10/11] RISC-V: Adding T-Head FMemIdx extension Christoph Muellner
2022-09-08 7:45 ` Richard Henderson [this message]
2022-09-09 17:21 ` Christoph Müllner
2022-09-06 12:22 ` [PATCH 11/11] RISC-V: Add initial support for T-Head C906 and C910 CPUs Christoph Muellner
2022-09-08 7:46 ` Richard Henderson
2022-09-08 8:23 ` Christoph Müllner
2022-09-08 8:56 ` Richard Henderson
2022-09-08 9:01 ` Christoph Müllner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=13c9f7be-d8b8-37aa-ee99-79056e11e30c@linaro.org \
--to=richard.henderson@linaro.org \
--cc=alistair.francis@wdc.com \
--cc=bin.meng@windriver.com \
--cc=christoph.muellner@vrull.eu \
--cc=cooper.qu@linux.alibaba.com \
--cc=heiko.stuebner@vrull.eu \
--cc=kito.cheng@sifive.com \
--cc=lifang_xia@linux.alibaba.com \
--cc=nelson@rivosinc.com \
--cc=palmer@dabbelt.com \
--cc=philipp.tomsich@vrull.eu \
--cc=qemu-devel@nongnu.org \
--cc=qemu-riscv@nongnu.org \
--cc=yunhai@linux.alibaba.com \
--cc=zhiwei_liu@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).