From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EDBF6ECAAD5 for ; Thu, 8 Sep 2022 07:47:48 +0000 (UTC) Received: from localhost ([::1]:54890 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oWCGI-0001xZ-R3 for qemu-devel@archiver.kernel.org; Thu, 08 Sep 2022 03:47:46 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36684) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oWCDq-0000xb-Rc for qemu-devel@nongnu.org; Thu, 08 Sep 2022 03:45:14 -0400 Received: from mail-wr1-x42f.google.com ([2a00:1450:4864:20::42f]:43771) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oWCDp-00037s-3B for qemu-devel@nongnu.org; Thu, 08 Sep 2022 03:45:14 -0400 Received: by mail-wr1-x42f.google.com with SMTP id t7so19548115wrm.10 for ; Thu, 08 Sep 2022 00:45:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=4zzKIZ/+RqOdZA78fKp4w6y0CFuWcdUNpdJy1AhCoF0=; b=PffCH5xmQG18nbbveiKb9csIpnesERHOmqSZR4ITprbSv+l4DXxB1soi2tlsyKmnXb 9JxPPbgsRPFvJcqPILf+1OUuI/cpIhqmZxpcJ6W14ScMU4URB10QcO+b8lg/RR/RcNt3 9L0nReL+WrUIF+JhquFNiJ9lVtx5CYRkZTl1zzgdkjQ0hcvKRp+nWoQ7p8DZaDfL3lyV kxDXSdjMa81ghl8rv3BHVCYmr78RdtN0Jy70KMJU1KvtGndTQ2+U1Qz9eIb2jK891x52 Y5FSoR/Lzcxe1tq+n5y+lV5CCUZz3SXSPBW3n7jMPWXu9iywT7t1+IFGazk3AHOCefjz bSMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=4zzKIZ/+RqOdZA78fKp4w6y0CFuWcdUNpdJy1AhCoF0=; b=PcAARFYKG6BBVSJpssoQNm+A6utuWxR1kTO7RZgvBC5cF+NBF2wXT/GDzIzdWx6Hg0 U18lRu1ycn5wnBuitc7jOZXp7qaOPTwbKczL9uKga5oCjcpFnceb/HPoNUsXjAwfCvmp yhAcLs1QCoMGgU1eIeeBToE8R/FQtdgUOA+qNDsJncQ67HS/J7vzYspM4CrQAHJSA3vJ mAd0rCCjNmDGed0RtNEOXdpIPb4dV1h2TN75h7+5j1j1qNBBa/iiJa+AJohb8iDH8Su/ 6dCCF7YwPg1soAg1coAY4qHTgzys3XrgsrnbXGmMxQqB+E7OZlwOdtx9Hg+gp3aLZWOy d4Uw== X-Gm-Message-State: ACgBeo3OeHkosGxic/nnO4z6y64HjwKUWmQvKJzTYYVr0rHVH2Zs8qxe W7K5EW9YTAhrelpNCyL2sLjnjA== X-Google-Smtp-Source: AA6agR49ZSujlBV3Ig1Xxgh5mlmtgxBREGpKrhy/R6Tt12OuipL6N0XQKIRLbp3KazY0qCa8jP55hA== X-Received: by 2002:a05:6000:1881:b0:222:c899:cac6 with SMTP id a1-20020a056000188100b00222c899cac6mr4008613wri.283.1662623111061; Thu, 08 Sep 2022 00:45:11 -0700 (PDT) Received: from [192.168.1.87] ([109.78.97.14]) by smtp.gmail.com with ESMTPSA id a18-20020adffb92000000b002237fd66585sm18686348wrr.92.2022.09.08.00.45.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 08 Sep 2022 00:45:10 -0700 (PDT) Message-ID: <13c9f7be-d8b8-37aa-ee99-79056e11e30c@linaro.org> Date: Thu, 8 Sep 2022 08:45:08 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH 10/11] RISC-V: Adding T-Head FMemIdx extension Content-Language: en-US To: Christoph Muellner , qemu-riscv@nongnu.org, qemu-devel@nongnu.org, Alistair Francis , Bin Meng , Philipp Tomsich , =?UTF-8?Q?Heiko_St=c3=bcbner?= , Palmer Dabbelt , Nelson Chu , Kito Cheng , Cooper Qu , Lifang Xia , Yunhai Shang , Zhiwei Liu References: <20220906122243.1243354-1-christoph.muellner@vrull.eu> <20220906122243.1243354-11-christoph.muellner@vrull.eu> From: Richard Henderson In-Reply-To: <20220906122243.1243354-11-christoph.muellner@vrull.eu> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2a00:1450:4864:20::42f; envelope-from=richard.henderson@linaro.org; helo=mail-wr1-x42f.google.com X-Spam_score_int: -62 X-Spam_score: -6.3 X-Spam_bar: ------ X-Spam_report: (-6.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-4.199, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 9/6/22 13:22, Christoph Muellner wrote: > @@ -732,6 +733,7 @@ static int ex_rvc_shifti(DisasContext *ctx, int imm) > #include "decode-xtheadbs.c.inc" > #include "decode-xtheadcmo.c.inc" > #include "decode-xtheadcondmov.c.inc" > +#include "decode-xtheadfmemidx.c.inc" > #include "decode-xtheadmac.c.inc" > #include "decode-xtheadmemidx.c.inc" > #include "decode-xtheadmempair.c.inc" > @@ -1061,6 +1063,7 @@ static void decode_opc(CPURISCVState *env, DisasContext *ctx, uint16_t opcode) > { has_xtheadbs_p, decode_xtheadbs }, > { has_xtheadcmo_p, decode_xtheadcmo }, > { has_xtheadcondmov_p, decode_xtheadcondmov }, > + { has_xtheadfmemidx_p, decode_xtheadfmemidx }, > { has_xtheadmac_p, decode_xtheadmac }, > { has_xtheadmemidx_p, decode_xtheadmemidx }, > { has_xtheadmempair_p, decode_xtheadmempair }, I think you should have a single decoder for all of the xthread extensions, and each translate function should test for the individual extension. You know up-front that these extensions do not conflict. r~