* [PATCH v2] char: don't fail when client is not connected
@ 2021-02-09 5:49 Pavel Dovgalyuk
2021-02-24 8:26 ` Pavel Dovgalyuk
2021-02-25 10:10 ` Paolo Bonzini
0 siblings, 2 replies; 3+ messages in thread
From: Pavel Dovgalyuk @ 2021-02-09 5:49 UTC (permalink / raw)
To: qemu-devel; +Cc: pbonzini, pavel.dovgalyuk, berrange, marcandre.lureau
This patch checks that ioc is not null before
using it in tcp socket tcp_chr_add_watch function.
The failure occurs in replay mode of the execution,
when monitor and serial port are tcp servers,
and there are no clients connected to them:
-monitor tcp:127.0.0.1:8081,server,nowait
-serial tcp:127.0.0.1:8082,server,nowait
Signed-off-by: Pavel Dovgalyuk <Pavel.Dovgalyuk@ispras.ru>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
---
chardev/char-socket.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/chardev/char-socket.c b/chardev/char-socket.c
index 213a4c8dd0..cef1d9438f 100644
--- a/chardev/char-socket.c
+++ b/chardev/char-socket.c
@@ -385,6 +385,9 @@ static ssize_t tcp_chr_recv(Chardev *chr, char *buf, size_t len)
static GSource *tcp_chr_add_watch(Chardev *chr, GIOCondition cond)
{
SocketChardev *s = SOCKET_CHARDEV(chr);
+ if (!s->ioc) {
+ return NULL;
+ }
return qio_channel_create_watch(s->ioc, cond);
}
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH v2] char: don't fail when client is not connected
2021-02-09 5:49 [PATCH v2] char: don't fail when client is not connected Pavel Dovgalyuk
@ 2021-02-24 8:26 ` Pavel Dovgalyuk
2021-02-25 10:10 ` Paolo Bonzini
1 sibling, 0 replies; 3+ messages in thread
From: Pavel Dovgalyuk @ 2021-02-24 8:26 UTC (permalink / raw)
To: qemu-devel; +Cc: pbonzini, berrange, marcandre.lureau
ping
On 09.02.2021 08:49, Pavel Dovgalyuk wrote:
> This patch checks that ioc is not null before
> using it in tcp socket tcp_chr_add_watch function.
>
> The failure occurs in replay mode of the execution,
> when monitor and serial port are tcp servers,
> and there are no clients connected to them:
>
> -monitor tcp:127.0.0.1:8081,server,nowait
> -serial tcp:127.0.0.1:8082,server,nowait
>
>
> Signed-off-by: Pavel Dovgalyuk <Pavel.Dovgalyuk@ispras.ru>
> Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
> chardev/char-socket.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/chardev/char-socket.c b/chardev/char-socket.c
> index 213a4c8dd0..cef1d9438f 100644
> --- a/chardev/char-socket.c
> +++ b/chardev/char-socket.c
> @@ -385,6 +385,9 @@ static ssize_t tcp_chr_recv(Chardev *chr, char *buf, size_t len)
> static GSource *tcp_chr_add_watch(Chardev *chr, GIOCondition cond)
> {
> SocketChardev *s = SOCKET_CHARDEV(chr);
> + if (!s->ioc) {
> + return NULL;
> + }
> return qio_channel_create_watch(s->ioc, cond);
> }
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH v2] char: don't fail when client is not connected
2021-02-09 5:49 [PATCH v2] char: don't fail when client is not connected Pavel Dovgalyuk
2021-02-24 8:26 ` Pavel Dovgalyuk
@ 2021-02-25 10:10 ` Paolo Bonzini
1 sibling, 0 replies; 3+ messages in thread
From: Paolo Bonzini @ 2021-02-25 10:10 UTC (permalink / raw)
To: Pavel Dovgalyuk, qemu-devel; +Cc: marcandre.lureau, berrange
On 09/02/21 06:49, Pavel Dovgalyuk wrote:
> This patch checks that ioc is not null before
> using it in tcp socket tcp_chr_add_watch function.
>
> The failure occurs in replay mode of the execution,
> when monitor and serial port are tcp servers,
> and there are no clients connected to them:
>
> -monitor tcp:127.0.0.1:8081,server,nowait
> -serial tcp:127.0.0.1:8082,server,nowait
>
>
> Signed-off-by: Pavel Dovgalyuk <Pavel.Dovgalyuk@ispras.ru>
> Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
> chardev/char-socket.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/chardev/char-socket.c b/chardev/char-socket.c
> index 213a4c8dd0..cef1d9438f 100644
> --- a/chardev/char-socket.c
> +++ b/chardev/char-socket.c
> @@ -385,6 +385,9 @@ static ssize_t tcp_chr_recv(Chardev *chr, char *buf, size_t len)
> static GSource *tcp_chr_add_watch(Chardev *chr, GIOCondition cond)
> {
> SocketChardev *s = SOCKET_CHARDEV(chr);
> + if (!s->ioc) {
> + return NULL;
> + }
> return qio_channel_create_watch(s->ioc, cond);
> }
>
>
Queued, thanks.
Paolo
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-02-25 10:11 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-02-09 5:49 [PATCH v2] char: don't fail when client is not connected Pavel Dovgalyuk
2021-02-24 8:26 ` Pavel Dovgalyuk
2021-02-25 10:10 ` Paolo Bonzini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).