From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9FDC8C433E0 for ; Tue, 2 Feb 2021 17:06:19 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1B75F64F87 for ; Tue, 2 Feb 2021 17:06:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1B75F64F87 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:46424 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l6z85-0001rB-Uo for qemu-devel@archiver.kernel.org; Tue, 02 Feb 2021 12:06:17 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:55252) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l6yhy-0006O4-W8 for qemu-devel@nongnu.org; Tue, 02 Feb 2021 11:39:19 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:32947) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1l6yhx-0004uY-AA for qemu-devel@nongnu.org; Tue, 02 Feb 2021 11:39:18 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1612283956; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=upnt39CyCVwBoTycKyW7rsDh22PJi9fn/RtxLu9lyuM=; b=V/WmgRD+IGzymorZ3crsLTT2FfcNLXqtIxIW1KPcEaKfuq9cPc//GD1EKFF76jjN9kyuYl 6GQVlioPZM0NY78+iQ3Ea9XJIgW/zhSAjEeUeeU07/8sHjgoCszLWoiwzoGxcR05P+ONry jM7HY89qM7Eme+4P1u/Gbv0iyz5K3qI= Received: from mail-ed1-f71.google.com (mail-ed1-f71.google.com [209.85.208.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-494-T63QKNl1Pvm3W01Hf0ODrg-1; Tue, 02 Feb 2021 11:39:13 -0500 X-MC-Unique: T63QKNl1Pvm3W01Hf0ODrg-1 Received: by mail-ed1-f71.google.com with SMTP id t9so9863272edd.3 for ; Tue, 02 Feb 2021 08:39:12 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=upnt39CyCVwBoTycKyW7rsDh22PJi9fn/RtxLu9lyuM=; b=sc7wOryn1DO+ZEFOodH3eVZ4DP6WEsZlG2bjIyyKJ/UhL37+aWqQi9sEgn0/0E4Yqs hzjm5QDIlOXabBxcJaU7IQKic5LZGxX8P7VWPfKninHZZ4h/TPitSRReINvjJy3BPNms x6dfDCjwfVMc6u4/XnKGL5iugKjVUPo6U7d+eejS3T70xXoH6MWICog+C1wV3mLGR/Ae ZVNyAiOXlgywmKs8QK4DOoQAZpQCDI4yNpOsgCOd1zbAhQt6rmcnjBERx6G70wVP/RW8 XPjsFhxT0OrCTPmZoao7uZilNBq/4BPBmA502rl2/Gc+aWbbM39x0hYdO5L34QFelcXf UQRw== X-Gm-Message-State: AOAM533pVpt5X9ppfLihUVsC7fzkRB1+90Y8y5Z87eNTlprLorhfjWgO wPMSvJIs0e3WwOXSUx/lDi3tBoSAyFCNH1yvYRjtvR15Eh7bGWqAWpGmoRaI8sjG5/WJvjxOrdg 7v+5/dAjID3eF098= X-Received: by 2002:a17:906:c049:: with SMTP id bm9mr22307621ejb.535.1612283951852; Tue, 02 Feb 2021 08:39:11 -0800 (PST) X-Google-Smtp-Source: ABdhPJz2tklvRYuU9l0qDykZvY93YU17wJ9cDOV5rFXjVQAhMAYZL/Panns/oGzBvmoCNoRhjmIqiA== X-Received: by 2002:a17:906:c049:: with SMTP id bm9mr22307596ejb.535.1612283951672; Tue, 02 Feb 2021 08:39:11 -0800 (PST) Received: from ?IPv6:2001:b07:6468:f312:c8dd:75d4:99ab:290a? ([2001:b07:6468:f312:c8dd:75d4:99ab:290a]) by smtp.gmail.com with ESMTPSA id b1sm3313895eju.15.2021.02.02.08.39.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 02 Feb 2021 08:39:10 -0800 (PST) Subject: Re: [PATCH] hw/i386/xen: Remove dead code To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , qemu-devel@nongnu.org References: <20210202155644.998812-1-philmd@redhat.com> From: Paolo Bonzini Message-ID: <13e06470-e13d-31ef-f7a7-9370a01d8b1c@redhat.com> Date: Tue, 2 Feb 2021 17:39:08 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20210202155644.998812-1-philmd@redhat.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=pbonzini@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=63.128.21.124; envelope-from=pbonzini@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -32 X-Spam_score: -3.3 X-Spam_bar: --- X-Spam_report: (-3.3 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.386, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.155, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Stefano Stabellini , Eduardo Habkost , "Michael S. Tsirkin" , "qemu-trivial@nongnu.org" , Paul Durrant , Richard Henderson , Anthony Perard , xen-devel@lists.xenproject.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 02/02/21 16:56, Philippe Mathieu-Daudé wrote: > 'drivers_blacklisted' is never accessed, remove it. > > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/i386/xen/xen_platform.c | 13 ++----------- > 1 file changed, 2 insertions(+), 11 deletions(-) > > diff --git a/hw/i386/xen/xen_platform.c b/hw/i386/xen/xen_platform.c > index 7c4db35debb..01ae1fb1618 100644 > --- a/hw/i386/xen/xen_platform.c > +++ b/hw/i386/xen/xen_platform.c > @@ -60,7 +60,6 @@ struct PCIXenPlatformState { > MemoryRegion bar; > MemoryRegion mmio_bar; > uint8_t flags; /* used only for version_id == 2 */ > - int drivers_blacklisted; > uint16_t driver_product_version; > > /* Log from guest drivers */ > @@ -245,18 +244,10 @@ static void platform_fixed_ioport_writeb(void *opaque, uint32_t addr, uint32_t v > > static uint32_t platform_fixed_ioport_readw(void *opaque, uint32_t addr) > { > - PCIXenPlatformState *s = opaque; > - > switch (addr) { > case 0: > - if (s->drivers_blacklisted) { > - /* The drivers will recognise this magic number and refuse > - * to do anything. */ > - return 0xd249; > - } else { > - /* Magic value so that you can identify the interface. */ > - return 0x49d2; > - } > + /* Magic value so that you can identify the interface. */ > + return 0x49d2; > default: > return 0xffff; > } > Cc: qemu-trivial@nongnu.org