From: Thomas Huth <thuth@redhat.com>
To: Stefan Hajnoczi <stefanha@redhat.com>, qemu-devel@nongnu.org
Cc: Laurent Vivier <lvivier@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Emanuele Giuseppe Esposito <eesposit@redhat.com>
Subject: Re: [PATCH 2/2] docs/devel/qgraph: add troubleshooting information
Date: Sat, 10 Apr 2021 06:41:03 +0200 [thread overview]
Message-ID: <13fb9be3-e928-d404-bcfe-25be7ef611d6@redhat.com> (raw)
In-Reply-To: <20210409190109.476167-3-stefanha@redhat.com>
On 09/04/2021 21.01, Stefan Hajnoczi wrote:
> It can be tricky to troubleshoot qos-test when a test won't execute. Add
> an explanation of how to trace qgraph node connectivity and find which
> node has the problem.
>
> Cc: Emanuele Giuseppe Esposito <eesposit@redhat.com>
> Cc: Paolo Bonzini <pbonzini@redhat.com>
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> ---
> docs/devel/qgraph.rst | 58 +++++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 58 insertions(+)
>
> diff --git a/docs/devel/qgraph.rst b/docs/devel/qgraph.rst
> index a9aff167ad..4635efb2c2 100644
> --- a/docs/devel/qgraph.rst
> +++ b/docs/devel/qgraph.rst
> @@ -92,6 +92,64 @@ The basic framework steps are the following:
> Depending on the QEMU binary used, only some drivers/machines will be
> available and only test that are reached by them will be executed.
>
> +Troubleshooting unavailable tests
> +^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> +If there is no path from an available machine to a test then that test will
> +unavailable and cannot execute. This can happen if a test or driver did not set
"will be unavailable" ? or "will be marked as unavailable" ?
Apart from that, patch looks fine to me.
Thomas
next prev parent reply other threads:[~2021-04-10 4:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-09 19:01 [PATCH 0/2] docs/devel/qgraph: add troubleshooting information Stefan Hajnoczi
2021-04-09 19:01 ` [PATCH 1/2] libqos/qgraph: fix "UNAVAILBLE" typo Stefan Hajnoczi
2021-04-09 20:03 ` Philippe Mathieu-Daudé
2021-04-09 19:01 ` [PATCH 2/2] docs/devel/qgraph: add troubleshooting information Stefan Hajnoczi
2021-04-10 4:41 ` Thomas Huth [this message]
2021-04-12 14:34 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=13fb9be3-e928-d404-bcfe-25be7ef611d6@redhat.com \
--to=thuth@redhat.com \
--cc=eesposit@redhat.com \
--cc=lvivier@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).