qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Gerd Hoffmann <kraxel@redhat.com>, qemu-devel@nongnu.org
Cc: "Fam Zheng" <fam@euphon.net>, "Ed Maste" <emaste@freebsd.org>,
	"Kamil Rytarowski" <kamil@netbsd.org>,
	"Alex Bennée" <alex.bennee@linaro.org>,
	"Li-Wen Hsu" <lwhsu@freebsd.org>,
	"Brad Smith" <brad@comstyle.com>
Subject: Re: [Qemu-devel] [PATCH v2 07/13] tests/vm: add DEBUG=1 to help text
Date: Sun, 19 May 2019 00:23:00 +0200	[thread overview]
Message-ID: <13ff85ac-6804-129f-dcec-4146130daa27@redhat.com> (raw)
In-Reply-To: <20190510104633.9428-8-kraxel@redhat.com>

Hi Gerd,

On 5/10/19 12:46 PM, Gerd Hoffmann wrote:
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
>  tests/vm/Makefile.include | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/tests/vm/Makefile.include b/tests/vm/Makefile.include
> index 47084d5717c6..8714b5947958 100644
> --- a/tests/vm/Makefile.include
> +++ b/tests/vm/Makefile.include
> @@ -25,6 +25,8 @@ vm-test:
>  	@echo "  vm-boot-ssh-<guest>             - Boot guest and login via ssh"
>  	@echo
>  	@echo "Special variables:"
> +	@echo "    DEBUG=1			 - be verbose, also start interactive"
> +	@echo "					   shell on build failures"

Can you replace <tabs> by <spaces>? See:

Special variables:
    DEBUG=1                      - be verbose, also start interactive
                                           shell on build failures
    BUILD_TARGET=foo             - override the build target
    TARGET_LIST=a,b,c            - Override target list in builds.
    EXTRA_CONFIGURE_OPTS="..."

Using spaces:
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>

>  	@echo "    BUILD_TARGET=foo		 - override the build target"
>  	@echo "    TARGET_LIST=a,b,c    	 - Override target list in builds."
>  	@echo '    EXTRA_CONFIGURE_OPTS="..."'
> 




  reply	other threads:[~2019-05-18 22:23 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-10 10:46 [Qemu-devel] [PATCH v2 00/13] tests/vm: serial console autoinstall, misc fixes Gerd Hoffmann
2019-05-10 10:46 ` [Qemu-devel] [PATCH v2 01/13] scripts: use git archive in archive-source Gerd Hoffmann
2019-05-10 10:46 ` [Qemu-devel] [PATCH v2 02/13] tests/vm: send proxy environment variables over ssh Gerd Hoffmann
2019-05-18 22:15   ` Philippe Mathieu-Daudé
2019-05-10 10:46 ` [Qemu-devel] [PATCH v2 03/13] tests/vm: use ssh with pty unconditionally Gerd Hoffmann
2019-05-10 10:46 ` [Qemu-devel] [PATCH v2 04/13] tests/vm: run test builds on snapshot Gerd Hoffmann
2019-05-10 10:46 ` [Qemu-devel] [PATCH v2 05/13] tests/vm: proper guest shutdown Gerd Hoffmann
2019-05-10 10:46 ` [Qemu-devel] [PATCH v2 06/13] tests/vm: add vm-boot-{ssh, serial}-<guest> targets Gerd Hoffmann
2019-05-10 10:46 ` [Qemu-devel] [PATCH v2 07/13] tests/vm: add DEBUG=1 to help text Gerd Hoffmann
2019-05-18 22:23   ` Philippe Mathieu-Daudé [this message]
2019-05-10 10:46 ` [Qemu-devel] [PATCH v2 08/13] tests/vm: serial console support helpers Gerd Hoffmann
2019-05-10 10:46 ` [Qemu-devel] [PATCH v2 09/13] tests/vm: openbsd autoinstall, using serial console Gerd Hoffmann
2019-05-10 10:46 ` [Qemu-devel] [PATCH v2 10/13] tests/vm: freebsd " Gerd Hoffmann
2019-05-18 22:55   ` Philippe Mathieu-Daudé
2019-05-20  5:26     ` Gerd Hoffmann
2019-05-20  7:14       ` Thomas Huth
2019-05-20 11:24         ` Philippe Mathieu-Daudé
2019-05-20 12:18           ` Gerd Hoffmann
2019-05-10 10:46 ` [Qemu-devel] [PATCH v2 11/13] tests/vm: netbsd " Gerd Hoffmann
2019-05-16  5:16   ` Kamil Rytarowski
2019-05-10 10:46 ` [Qemu-devel] [PATCH v2 12/13] tests/vm: fedora " Gerd Hoffmann
2019-05-10 10:46 ` [Qemu-devel] [PATCH v2 13/13] tests/vm: ubuntu.i386: apt proxy setup Gerd Hoffmann
2019-05-18 22:18   ` Philippe Mathieu-Daudé
2019-05-17  1:04 ` [Qemu-devel] QEMU on OpenBSD is broken? (was: Re: [PATCH v2 00/13] tests/vm: serial console autoinstall, misc fixes.) Thomas Huth
2019-05-18 21:27   ` [Qemu-devel] QEMU on OpenBSD is broken? Jim Payne
2019-05-19  4:27     ` Brad Smith
2019-05-20  7:54     ` Gerd Hoffmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=13ff85ac-6804-129f-dcec-4146130daa27@redhat.com \
    --to=philmd@redhat.com \
    --cc=alex.bennee@linaro.org \
    --cc=brad@comstyle.com \
    --cc=emaste@freebsd.org \
    --cc=fam@euphon.net \
    --cc=kamil@netbsd.org \
    --cc=kraxel@redhat.com \
    --cc=lwhsu@freebsd.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).