From: Mike Day <ncmike@ncultra.org>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, peter.maydell@linaro.org,
Mike Day <ncmike@ncultra.org>,
stefanha@redhat.com, cornelia.huck@de.ibm.com, ambru@redhat.com
Subject: [Qemu-devel] [PATCH] Remove g_sequence_lookup from qemu-img help function
Date: Tue, 13 May 2014 14:34:29 -0400 [thread overview]
Message-ID: <1400006069-11143-1-git-send-email-ncmike@ncultra.org> (raw)
g_sequence_lookup is not supported by glib < 2.28. The usage
of g_sequence_lookup is not essential in this context (its a
safeguard against duplicate values in the help message).
Removing the call enables the build on all platforms and
does not change the operation of the help function.
Signed-off-by: Mike Day <ncmike@ncultra.org>
---
qemu-img.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/qemu-img.c b/qemu-img.c
index 04ce02a..bf5e74c 100644
--- a/qemu-img.c
+++ b/qemu-img.c
@@ -70,11 +70,8 @@ static void add_format_to_seq(void *opaque, const char *fmt_name)
{
GSequence *seq = opaque;
- if (!g_sequence_lookup(seq, (gpointer)fmt_name,
- compare_data, NULL)) {
g_sequence_insert_sorted(seq, (gpointer)fmt_name,
compare_data, NULL);
- }
}
static void QEMU_NORETURN GCC_FMT_ATTR(1, 2) error_exit(const char *fmt, ...)
--
1.9.0
next reply other threads:[~2014-05-13 18:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-13 18:34 Mike Day [this message]
2014-05-13 19:37 ` [Qemu-devel] [PATCH] Remove g_sequence_lookup from qemu-img help function Eric Blake
-- strict thread matches above, loose matches on Subject: below --
2014-05-13 21:11 Mike Day
2014-05-13 21:48 ` Eric Blake
2014-05-14 7:44 ` Kevin Wolf
2014-05-14 8:23 ` Peter Maydell
2014-05-16 12:35 ` Alexander Graf
2014-05-14 6:31 ` Cornelia Huck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1400006069-11143-1-git-send-email-ncmike@ncultra.org \
--to=ncmike@ncultra.org \
--cc=ambru@redhat.com \
--cc=cornelia.huck@de.ibm.com \
--cc=kwolf@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).