qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Hajnoczi <stefanha@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Kevin Wolf" <kwolf@redhat.com>,
	"Benoît Canet" <benoit@irqsave.net>,
	"Stefan Hajnoczi" <stefanha@redhat.com>
Subject: [Qemu-devel] [PATCH 0/3] throttle: use AioContext for dataplane support
Date: Wed, 14 May 2014 16:22:44 +0200	[thread overview]
Message-ID: <1400077367-23409-1-git-send-email-stefanha@redhat.com> (raw)

This series applies on top of my "dataplane: use QEMU block layer" series.

Now that the dataplane code path is using the QEMU block layer we should make
I/O throttling limits safe to use.  When the block_set_io_throttle monitor
command is executed, the BlockDriverState's AioContext must be acquired in
order to prevent race conditions with the IOThread that is processing requests
from the guest.

The new block layer AioContext detach/attach mechanism needs to be extended to
move the throttling timer to a new AioContext.  This makes throttling work
across bdrv_set_aio_context() calls.

The result of this series is that I/O throttling works with dataplane and
limits may be changed at runtime using the monitor.

Stefan Hajnoczi (3):
  throttle: add throttle_detach/attach_aio_context()
  throttle: add detach/attach test case
  blockdev: acquire AioContext in block_set_io_throttle

 block.c                 |  7 +++++++
 blockdev.c              |  6 ++++++
 include/qemu/throttle.h | 10 ++++++++++
 tests/test-throttle.c   | 49 ++++++++++++++++++++++++++++++++++++++++++++-----
 util/throttle.c         | 27 +++++++++++++++++++++++----
 5 files changed, 90 insertions(+), 9 deletions(-)

-- 
1.9.0

             reply	other threads:[~2014-05-14 14:23 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-14 14:22 Stefan Hajnoczi [this message]
2014-05-14 14:22 ` [Qemu-devel] [PATCH 1/3] throttle: add throttle_detach/attach_aio_context() Stefan Hajnoczi
2014-05-14 15:05   ` Benoît Canet
2014-05-15  7:57     ` Stefan Hajnoczi
2014-05-15 11:25   ` Benoît Canet
2014-05-14 14:22 ` [Qemu-devel] [PATCH 2/3] throttle: add detach/attach test case Stefan Hajnoczi
2014-05-14 15:08   ` Benoît Canet
2014-05-14 14:22 ` [Qemu-devel] [PATCH 3/3] blockdev: acquire AioContext in block_set_io_throttle Stefan Hajnoczi
2014-05-14 15:11   ` Benoît Canet
2014-05-14 15:14 ` [Qemu-devel] [PATCH 0/3] throttle: use AioContext for dataplane support Benoît Canet
2014-05-14 17:40 ` Benoît Canet
2014-05-15  7:46   ` Stefan Hajnoczi
2014-06-03 13:44 ` Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1400077367-23409-1-git-send-email-stefanha@redhat.com \
    --to=stefanha@redhat.com \
    --cc=benoit@irqsave.net \
    --cc=kwolf@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).