From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34830) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WkdSJ-0003sj-C7 for qemu-devel@nongnu.org; Wed, 14 May 2014 13:59:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WkdSE-0001zH-IH for qemu-devel@nongnu.org; Wed, 14 May 2014 13:59:03 -0400 Message-ID: <1400088577.14303.45.camel@localhost.localdomain> From: Marcel Apfelbaum Date: Wed, 14 May 2014 20:29:37 +0300 In-Reply-To: <5373A11E.90005@suse.de> References: <1399473780-20374-1-git-send-email-marcel.a@redhat.com> <1399473780-20374-3-git-send-email-marcel.a@redhat.com> <53725800.3030404@suse.de> <53726D96.8030404@redhat.com> <5373A11E.90005@suse.de> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 2/4] qapi: output visitor crashes qemu if it encounters a NULL value List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Andreas =?ISO-8859-1?Q?F=E4rber?= Cc: mst@redhat.com, aik@ozlabs.ru, qemu-devel@nongnu.org, Luiz Capitulino , blauwirbel@gmail.com, jcmvbkbc@gmail.com, edgar.iglesias@gmail.com, gxt@mprc.pku.edu.cn, peter.chubb@nicta.com.au, proljc@gmail.com, agraf@suse.de, scottwood@freescale.com, borntraeger@de.ibm.com, hpoussin@reactos.org, aliguori@amazon.com, lersek@redhat.com, mdroth@linux.vnet.ibm.com, chouteau@adacore.com, jan.kiszka@web.de, stefanha@redhat.com, cornelia.huck@de.ibm.com, peter.crosthwaite@xilinx.com, mark.langsdorf@calxeda.com, armbru@redhat.com, michael@walle.cc, qemu-ppc@nongnu.org, pbonzini@redhat.com, aurelien@aurel32.net On Wed, 2014-05-14 at 19:00 +0200, Andreas F=C3=A4rber wrote: > Am 13.05.2014 21:08, schrieb Eric Blake: > > On 05/13/2014 11:36 AM, Andreas F=C3=A4rber wrote: > >> Am 07.05.2014 16:42, schrieb Marcel Apfelbaum: > >>> A NULL value is not added to visitor's stack, but there is no > >>> check for that when the visitor tries to return that value, > >>> leading to Qemu crash. > >>>=20 > >>> Reviewed-by: Eric Blake Signed-off-by: > >>> Marcel Apfelbaum > >>=20 > >> Where does the Rb come from on this v1? Is it in any tree > >> already? > >>=20 > >=20 > > The (weak) R-b was here:=20 > > https://lists.gnu.org/archive/html/qemu-devel/2014-02/msg02861.html >=20 > Thanks. > >=20 > So Luiz was okay with it too, but his last message seems to be > indicating this needs to be fixed somewhere else, too: >=20 > https://lists.gnu.org/archive/html/qemu-devel/2014-02/msg05228.html > https://lists.gnu.org/archive/html/qemu-devel/2014-03/msg00217.html >=20 > Can/should that be addressed as a follow-up? Or is there a test case > that breaks? Simple and "popular" test case: the user does not use the -kernel-cmdline= parameter. The patch is needed because otherwise the main function will fail if no value is passed by the user to string parameters.=20 Regarding Luiz's concern, it can be a follow-up as I am not aware of any problem with that. Thanks, Marcel >=20 > Regards, > Andreas >=20