From: Eduardo Habkost <ehabkost@redhat.com>
To: qemu-devel@nongnu.org, "Andreas Färber" <afaerber@suse.de>
Subject: [Qemu-devel] [PATCH RESEND v4 04/18] target-i386: Pass FeatureWord argument to report_unavailable_features()
Date: Wed, 14 May 2014 16:29:56 -0300 [thread overview]
Message-ID: <1400095810-27684-5-git-send-email-ehabkost@redhat.com> (raw)
In-Reply-To: <1400095810-27684-1-git-send-email-ehabkost@redhat.com>
This will help us simplify the code that calls
report_unavailable_features() later.
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
---
Changes v1 -> v2:
* Rebase to latest qom-cpu (commit 90c5d39c)
Changes v2 -> v3:
* Trivial rebase after QEMU 2.0 (onto commit 2d03b49)
---
target-i386/cpu.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/target-i386/cpu.c b/target-i386/cpu.c
index 370da81..b097c0d 100644
--- a/target-i386/cpu.c
+++ b/target-i386/cpu.c
@@ -1236,8 +1236,9 @@ static const TypeInfo host_x86_cpu_type_info = {
#endif
-static int report_unavailable_features(FeatureWordInfo *f, uint32_t mask)
+static int report_unavailable_features(FeatureWord w, uint32_t mask)
{
+ FeatureWordInfo *f = &feature_word_info[w];
int i;
for (i = 0; i < 32; ++i) {
@@ -1845,7 +1846,7 @@ static int filter_features_for_kvm(X86CPU *cpu)
cpu->filtered_features[w] = requested_features & ~env->features[w];
if (cpu->filtered_features[w]) {
if (cpu->check_cpuid || cpu->enforce_cpuid) {
- report_unavailable_features(wi, cpu->filtered_features[w]);
+ report_unavailable_features(w, cpu->filtered_features[w]);
}
rv = 1;
}
--
1.9.0
next prev parent reply other threads:[~2014-05-14 19:31 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-14 19:29 [Qemu-devel] [PATCH RESEND v4 00/18] target-i386: CPU feature flag queue Eduardo Habkost
2014-05-14 19:29 ` [Qemu-devel] [PATCH RESEND v4 01/18] target-i386: kvm: Don't enable MONITOR by default on any CPU model Eduardo Habkost
2014-05-14 19:29 ` [Qemu-devel] [PATCH RESEND v4 02/18] target-i386: Simplify reporting of unavailable features Eduardo Habkost
2014-05-14 19:29 ` [Qemu-devel] [PATCH RESEND v4 03/18] target-i386: Merge feature filtering/checking functions Eduardo Habkost
2014-05-14 19:29 ` Eduardo Habkost [this message]
2014-05-14 19:29 ` [Qemu-devel] [PATCH RESEND v4 05/18] target-i386: Isolate KVM-specific code on CPU feature filtering logic Eduardo Habkost
2014-05-14 19:29 ` [Qemu-devel] [PATCH RESEND v4 06/18] target-i386: Make TCG feature filtering more readable Eduardo Habkost
2014-05-14 19:29 ` [Qemu-devel] [PATCH RESEND v4 07/18] target-i386: Filter FEAT_7_0_EBX TCG features too Eduardo Habkost
2014-05-14 19:30 ` [Qemu-devel] [PATCH RESEND v4 08/18] target-i386: Filter KVM and 0xC0000001 features on TCG Eduardo Habkost
2014-05-14 19:30 ` [Qemu-devel] [PATCH RESEND v4 09/18] target-i386: Define TCG_*_FEATURES earlier on cpu.c Eduardo Habkost
2014-05-14 19:30 ` [Qemu-devel] [PATCH RESEND v4 10/18] target-i386: Loop-based copying and setting/unsetting of feature words Eduardo Habkost
2014-05-14 19:30 ` [Qemu-devel] [PATCH RESEND v4 11/18] target-i386: Loop-based feature word filtering in TCG mode Eduardo Habkost
2014-05-14 19:30 ` [Qemu-devel] [PATCH RESEND v4 12/18] target-i386: Support check/enforce flags in TCG mode, too Eduardo Habkost
2014-05-14 19:30 ` [Qemu-devel] [PATCH RESEND v4 13/18] target-i386: Support "-cpu host" in TCG mode Eduardo Habkost
2014-05-14 19:30 ` [Qemu-devel] [PATCH RESEND v4 14/18] target-i386: Add "migratable" property to "host" CPU model Eduardo Habkost
2014-05-14 19:30 ` [Qemu-devel] [PATCH RESEND v4 15/18] target-i386: Set migratable=yes by default Eduardo Habkost
2014-05-14 19:30 ` [Qemu-devel] [PATCH RESEND v4 16/18] savevm: check vmsd for migratability status Eduardo Habkost
2014-05-15 12:14 ` Juan Quintela
2014-05-15 13:08 ` Andreas Färber
2014-05-15 14:05 ` Juan Quintela
2014-05-15 14:15 ` Eduardo Habkost
2014-05-14 19:30 ` [Qemu-devel] [PATCH RESEND v4 17/18] target-i386: block migration and savevm if invariant tsc is exposed Eduardo Habkost
2014-05-15 12:17 ` Juan Quintela
2014-05-16 9:31 ` Marcelo Tosatti
2014-06-10 7:12 ` Amit Shah
2014-06-10 14:43 ` Eduardo Habkost
2014-06-13 12:35 ` Amit Shah
2014-05-14 19:30 ` [Qemu-devel] [PATCH RESEND v4 18/18] target-i386: support "invariant tsc" flag Eduardo Habkost
2014-05-14 20:44 ` [Qemu-devel] [PATCH RESEND v4 00/18] target-i386: CPU feature flag queue Andreas Färber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1400095810-27684-5-git-send-email-ehabkost@redhat.com \
--to=ehabkost@redhat.com \
--cc=afaerber@suse.de \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).