From: Gerd Hoffmann <kraxel@redhat.com>
To: "Gonglei (Arei)" <arei.gonglei@huawei.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
"Huangweidong (C)" <weidong.huang@huawei.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
"Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [Qemu-devel] usb: usb tablet freeze when save/restore guest os
Date: Thu, 15 May 2014 08:50:13 +0200 [thread overview]
Message-ID: <1400136613.2922.21.camel@nilsson.home.kraxel.org> (raw)
In-Reply-To: <33183CC9F5247A488A2544077AF19020815E8DBC@SZXEMA503-MBS.china.huawei.com>
Hi,
> Well then, may I post a formal patch for this issue, Gerd? Thanks.
I'd like to know what the root cause for the lost interrupt is.
Not implementing PIRQ enable could be it, especially as the guest os
seems to use it (otherwise your patch would have no effect).
The check for the PIRQ enable bit should be in uhci_update_irq though,
and you should check the single bit only, not the whole legacy support
register.
cheers,
Gerd
next prev parent reply other threads:[~2014-05-15 6:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-13 9:04 [Qemu-devel] usb: usb tablet freeze when save/restore guest os Gonglei (Arei)
2014-05-13 13:27 ` Gerd Hoffmann
2014-05-14 1:47 ` Gonglei (Arei)
2014-05-14 10:25 ` Paolo Bonzini
2014-05-15 2:00 ` Gonglei (Arei)
2014-05-15 6:50 ` Gerd Hoffmann [this message]
2014-05-15 11:23 ` Gonglei (Arei)
2014-05-20 10:25 ` Gerd Hoffmann
-- strict thread matches above, loose matches on Subject: below --
2014-05-13 9:34 Gonglei (Arei)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1400136613.2922.21.camel@nilsson.home.kraxel.org \
--to=kraxel@redhat.com \
--cc=arei.gonglei@huawei.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=weidong.huang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).