From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40247) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WkpVF-0000TS-Rj for qemu-devel@nongnu.org; Thu, 15 May 2014 02:51:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WkpV9-00010D-OG for qemu-devel@nongnu.org; Thu, 15 May 2014 02:50:53 -0400 Received: from mx1.redhat.com ([209.132.183.28]:31283) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WkpV9-0000zf-GN for qemu-devel@nongnu.org; Thu, 15 May 2014 02:50:47 -0400 Message-ID: <1400136613.2922.21.camel@nilsson.home.kraxel.org> From: Gerd Hoffmann Date: Thu, 15 May 2014 08:50:13 +0200 In-Reply-To: <33183CC9F5247A488A2544077AF19020815E8DBC@SZXEMA503-MBS.china.huawei.com> References: <33183CC9F5247A488A2544077AF19020815E8148@SZXEMA503-MBS.china.huawei.com> <1399987647.7118.63.camel@nilsson.home.kraxel.org> <33183CC9F5247A488A2544077AF19020815E873D@SZXEMA503-MBS.china.huawei.com> <537344AD.3030000@redhat.com> <33183CC9F5247A488A2544077AF19020815E8DBC@SZXEMA503-MBS.china.huawei.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] usb: usb tablet freeze when save/restore guest os List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Gonglei (Arei)" Cc: Paolo Bonzini , "Huangweidong (C)" , "qemu-devel@nongnu.org" , "Michael S. Tsirkin" Hi, > Well then, may I post a formal patch for this issue, Gerd? Thanks. I'd like to know what the root cause for the lost interrupt is. Not implementing PIRQ enable could be it, especially as the guest os seems to use it (otherwise your patch would have no effect). The check for the PIRQ enable bit should be in uhci_update_irq though, and you should check the single bit only, not the whole legacy support register. cheers, Gerd