From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: kevin@koconnor.net
Subject: [Qemu-devel] [PATCH 0/3] target-i386: fix CPL computation
Date: Thu, 15 May 2014 18:56:53 +0200 [thread overview]
Message-ID: <1400173016-27214-1-git-send-email-pbonzini@redhat.com> (raw)
CS.RPL is not equal to the CPL in the few instructions between
setting CR0.PE and reloading CS. We get this right in the common
case, because writes to CR0 do not modify the CPL, but it would
not be enough if an SMI comes exactly during that brief period.
So this patch fixes the CPL to come from SS.DPL instead, which
requires a couple changes to make access rights correct for VM86
mode, and to override the CPL to CS.RPL during task switches (more
details in patch 2).
Tested with FreeDOS and kvm-unit-tests.
Paolo Bonzini (3):
target-i386: fix segment flags for SMM and VM86 mode
target-i386: prepare CPL checks for next patch
target-i386: get CPL from SS.DPL
target-i386/cpu.h | 8 +++-----
target-i386/kvm.c | 2 +-
target-i386/machine.c | 8 ++++++++
target-i386/seg_helper.c | 27 ++++++++++++---------------
target-i386/smm_helper.c | 24 ++++++++++++++++++------
5 files changed, 42 insertions(+), 27 deletions(-)
--
1.8.3.1
next reply other threads:[~2014-05-15 16:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-15 16:56 Paolo Bonzini [this message]
2014-05-15 16:56 ` [Qemu-devel] [PATCH 1/3] target-i386: fix segment flags for SMM and VM86 mode Paolo Bonzini
2014-05-15 18:45 ` Kevin O'Connor
2014-05-16 7:33 ` Paolo Bonzini
2014-05-15 16:56 ` [Qemu-devel] [PATCH 2/3] target-i386: prepare CPL checks for next patch Paolo Bonzini
2014-05-15 16:56 ` [Qemu-devel] [PATCH 3/3] target-i386: get CPL from SS.DPL Paolo Bonzini
2014-05-15 18:38 ` Kevin O'Connor
2014-05-16 7:35 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1400173016-27214-1-git-send-email-pbonzini@redhat.com \
--to=pbonzini@redhat.com \
--cc=kevin@koconnor.net \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).