From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: Peter Lieven <pl@kamp.de>
Subject: [Qemu-devel] [PULL 10/11] block/iscsi: allow cluster_size of 4K and greater
Date: Fri, 16 May 2014 12:37:43 +0200 [thread overview]
Message-ID: <1400236664-32334-11-git-send-email-pbonzini@redhat.com> (raw)
In-Reply-To: <1400236664-32334-1-git-send-email-pbonzini@redhat.com>
From: Peter Lieven <pl@kamp.de>
depending on the target the opt_unmap_gran might be as low
as 4K. As we know use this also as a knob to activate the allocationmap
feature lower the barrier. The limit 4K (and not 512) is choosen
to avoid a potentially too big allocationmap.
Signed-off-by: Peter Lieven <pl@kamp.de>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
block/iscsi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/block/iscsi.c b/block/iscsi.c
index e8d26bb..84bedfa 100644
--- a/block/iscsi.c
+++ b/block/iscsi.c
@@ -1386,7 +1386,7 @@ static int iscsi_open(BlockDriverState *bs, QDict *options, int flags,
/* Guess the internal cluster (page) size of the iscsi target by the means
* of opt_unmap_gran. Transfer the unmap granularity only if it has a
* reasonable size */
- if (iscsilun->bl.opt_unmap_gran * iscsilun->block_size >= 64 * 1024 &&
+ if (iscsilun->bl.opt_unmap_gran * iscsilun->block_size >= 4 * 1024 &&
iscsilun->bl.opt_unmap_gran * iscsilun->block_size <= 16 * 1024 * 1024) {
iscsilun->cluster_sectors = (iscsilun->bl.opt_unmap_gran *
iscsilun->block_size) >> BDRV_SECTOR_BITS;
--
1.8.3.1
next prev parent reply other threads:[~2014-05-16 10:38 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-16 10:37 [Qemu-devel] [PULL 00/11] SCSI changes for 2014-05-15 Paolo Bonzini
2014-05-16 10:37 ` [Qemu-devel] [PULL 01/11] scsi-disk: Improve error messager if can't get version number Paolo Bonzini
2014-05-16 10:37 ` [Qemu-devel] [PULL 02/11] scsi: Improve error messages more Paolo Bonzini
2014-05-16 10:37 ` [Qemu-devel] [PULL 03/11] megasas: Implement LD_LIST_QUERY Paolo Bonzini
2014-05-16 10:37 ` [Qemu-devel] [PULL 04/11] megasas: Enable MSI-X support Paolo Bonzini
2014-05-16 10:37 ` [Qemu-devel] [PULL 05/11] megasas: Add MSI support Paolo Bonzini
2014-05-16 10:37 ` [Qemu-devel] [PULL 06/11] MAINTAINERS: mark megasas as maintained Paolo Bonzini
2014-05-16 10:37 ` [Qemu-devel] [PULL 07/11] block/iscsi: allow fall back to WRITE SAME without UNMAP Paolo Bonzini
2014-05-16 10:37 ` [Qemu-devel] [PULL 08/11] block/iscsi: speed up read for unallocated sectors Paolo Bonzini
2014-05-16 10:37 ` [Qemu-devel] [PULL 09/11] block/iscsi: clarify the meaning of ISCSI_CHECKALLOC_THRES Paolo Bonzini
2014-05-16 10:37 ` Paolo Bonzini [this message]
2014-05-16 10:37 ` [Qemu-devel] [PULL 11/11] [PATCH] block/iscsi: bump year in copyright notice Paolo Bonzini
2014-05-19 11:52 ` [Qemu-devel] [PULL 00/11] SCSI changes for 2014-05-15 Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1400236664-32334-11-git-send-email-pbonzini@redhat.com \
--to=pbonzini@redhat.com \
--cc=pl@kamp.de \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).