From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59788) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WlKJ1-0005pP-B4 for qemu-devel@nongnu.org; Fri, 16 May 2014 11:44:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WlKIr-0002X2-D1 for qemu-devel@nongnu.org; Fri, 16 May 2014 11:44:19 -0400 Received: from mx1.redhat.com ([209.132.183.28]:9032) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WlKIr-0002WL-5L for qemu-devel@nongnu.org; Fri, 16 May 2014 11:44:09 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s4GFi84I026508 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Fri, 16 May 2014 11:44:08 -0400 From: Markus Armbruster Date: Fri, 16 May 2014 17:44:05 +0200 Message-Id: <1400255046-24481-2-git-send-email-armbru@redhat.com> In-Reply-To: <1400255046-24481-1-git-send-email-armbru@redhat.com> References: <1400255046-24481-1-git-send-email-armbru@redhat.com> Subject: [Qemu-devel] [PATCH 1/2] scsi: Document intentional fall through in scsi_req_length() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: pbonzini@redhat.com For clarity, and to hush up Coverity. Signed-off-by: Markus Armbruster --- hw/scsi/scsi-bus.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/scsi/scsi-bus.c b/hw/scsi/scsi-bus.c index abe7302..06399fa 100644 --- a/hw/scsi/scsi-bus.c +++ b/hw/scsi/scsi-bus.c @@ -938,6 +938,7 @@ static int scsi_req_length(SCSICommand *cmd, SCSIDevice *dev, uint8_t *buf) if (cmd->xfer == 0) { cmd->xfer = 256; } + /* fall through */ case WRITE_10: case WRITE_VERIFY_10: case WRITE_12: @@ -952,6 +953,7 @@ static int scsi_req_length(SCSICommand *cmd, SCSIDevice *dev, uint8_t *buf) if (cmd->xfer == 0) { cmd->xfer = 256; } + /* fall through */ case READ_10: case RECOVER_BUFFERED_DATA: case READ_12: -- 1.8.1.4