From: "Marc Marí" <marc.mari.barcelo@gmail.com>
To: qemu-devel@nongnu.org
Cc: "Marc Marí" <marc.mari.barcelo@gmail.com>,
"Stefan Hajnoczi" <stefanha@gmail.com>,
"Peter Crosthwaite" <peter.crosthwaite@xilinx.com>,
"open list:sPAPR" <qemu-ppc@nongnu.org>,
"Andreas Färber" <afaerber@suse.de>
Subject: [Qemu-devel] [PATCH v3 07/16] spapr: Convert debug printfs to QEMU_DPRINTF
Date: Sun, 18 May 2014 01:03:34 +0200 [thread overview]
Message-ID: <1400367823-32610-8-git-send-email-marc.mari.barcelo@gmail.com> (raw)
In-Reply-To: <1400367823-32610-1-git-send-email-marc.mari.barcelo@gmail.com>
Modify debug macros to have the same format through the codebase and use regular
ifs instead of ifdef.
Signed-off-by: Marc Marí <marc.mari.barcelo@gmail.com>
Acked-by: Alexander Graf <agraf@suse.de>
---
hw/net/spapr_llan.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/hw/net/spapr_llan.c b/hw/net/spapr_llan.c
index c433337..1639f4b 100644
--- a/hw/net/spapr_llan.c
+++ b/hw/net/spapr_llan.c
@@ -39,11 +39,13 @@
/*#define DEBUG*/
#ifdef DEBUG
-#define DPRINTF(fmt...) do { fprintf(stderr, fmt); } while (0)
+#define DEBUG_ENABLED 1
#else
-#define DPRINTF(fmt...)
+#define DEBUG_ENABLED 0
#endif
+#define DPRINTF(fmt...) QEMU_DPRINTF(DEBUG_ENABLED, "spapr_llan", fmt)
+
/*
* Virtual LAN device
*/
--
1.7.10.4
next prev parent reply other threads:[~2014-05-17 23:04 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-17 23:03 [Qemu-devel] [PATCH v3 00/16] Convert debug printfs to QEMU_DPRINTF Marc Marí
2014-05-17 23:03 ` [Qemu-devel] [PATCH v3 01/16] include/qemu-common.h: Add QEMU_DPRINTF macro Marc Marí
2014-05-19 15:28 ` Eric Blake
2014-05-17 23:03 ` [Qemu-devel] [PATCH v3 02/16] x86: Convert debug printfs to QEMU_DPRINTF Marc Marí
2014-05-19 15:48 ` Eric Blake
2014-05-17 23:03 ` [Qemu-devel] [PATCH v3 03/16] s390: " Marc Marí
2014-05-18 9:37 ` Peter Crosthwaite
2014-05-19 11:50 ` Alexander Graf
2014-05-19 16:45 ` Marc Marí
2014-05-19 16:50 ` Richard Henderson
2014-05-19 20:33 ` Peter Crosthwaite
2014-05-19 20:34 ` Alexander Graf
2014-05-17 23:03 ` [Qemu-devel] [PATCH v3 04/16] scsi: " Marc Marí
2014-05-17 23:03 ` [Qemu-devel] [PATCH v3 05/16] highbank: " Marc Marí
2014-05-17 23:03 ` [Qemu-devel] [PATCH v3 06/16] xilinx: " Marc Marí
2014-05-17 23:03 ` Marc Marí [this message]
2014-05-17 23:03 ` [Qemu-devel] [PATCH v3 08/16] stellaris: " Marc Marí
2014-05-17 23:03 ` [Qemu-devel] [PATCH v3 09/16] i82374: " Marc Marí
2014-05-17 23:03 ` [Qemu-devel] [PATCH v3 10/16] i8257: " Marc Marí
2014-05-17 23:03 ` [Qemu-devel] [PATCH v3 11/16] rc4030: " Marc Marí
2014-05-17 23:03 ` [Qemu-devel] [PATCH v3 12/16] sd: " Marc Marí
2014-05-19 21:05 ` Eric Blake
2014-05-17 23:03 ` [Qemu-devel] [PATCH v3 13/16] isa: " Marc Marí
2014-05-19 21:07 ` Eric Blake
2014-05-20 6:39 ` Marc Marí
2014-05-17 23:03 ` [Qemu-devel] [PATCH v3 14/16] lan9118: " Marc Marí
2014-05-17 23:03 ` [Qemu-devel] [PATCH v3 15/16] pci-host: " Marc Marí
2014-05-17 23:03 ` [Qemu-devel] [PATCH v3 16/16] common: " Marc Marí
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1400367823-32610-8-git-send-email-marc.mari.barcelo@gmail.com \
--to=marc.mari.barcelo@gmail.com \
--cc=afaerber@suse.de \
--cc=peter.crosthwaite@xilinx.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).