From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59811) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WlwmM-0007Xw-SJ for qemu-devel@nongnu.org; Sun, 18 May 2014 04:49:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WlwmG-0007G1-KH for qemu-devel@nongnu.org; Sun, 18 May 2014 04:49:10 -0400 Message-ID: <1400402921.12073.6.camel@localhost.localdomain> From: Marcel Apfelbaum Date: Sun, 18 May 2014 11:48:41 +0300 In-Reply-To: <53765B10.6050506@suse.de> References: <1399473780-20374-1-git-send-email-marcel.a@redhat.com> <1399473780-20374-2-git-send-email-marcel.a@redhat.com> <20140516182011.5f3a3286@thinkpad> <53765B10.6050506@suse.de> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 1/4] machine: conversion of QEMUMachineInitArgs to MachineState List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Andreas =?ISO-8859-1?Q?F=E4rber?= Cc: mst@redhat.com, aik@ozlabs.ru, qemu-devel@nongnu.org, mdroth@linux.vnet.ibm.com, blauwirbel@gmail.com, jcmvbkbc@gmail.com, pbonzini@redhat.com, edgar.iglesias@gmail.com, gxt@mprc.pku.edu.cn, proljc@gmail.com, agraf@suse.de, scottwood@freescale.com, borntraeger@de.ibm.com, hpoussin@reactos.org, aliguori@amazon.com, lersek@redhat.com, chouteau@adacore.com, jan.kiszka@web.de, stefanha@redhat.com, Igor Mammedov , cornelia.huck@de.ibm.com, lcapitulino@redhat.com, peter.crosthwaite@xilinx.com, armbru@redhat.com, michael@walle.cc, qemu-ppc@nongnu.org, peter.chubb@nicta.com.au, aurelien@aurel32.net On Fri, 2014-05-16 at 20:38 +0200, Andreas F=C3=A4rber wrote: > Am 16.05.2014 18:20, schrieb Igor Mammedov: > > On Wed, 7 May 2014 17:42:57 +0300 > > Marcel Apfelbaum wrote: > >=20 > >> Total removal of QEMUMachineInitArgs struct. QEMUMachineInitArgs's f= ields > >> are copied into MachineState. Removed duplicated fields from Machine= State. > >> > >> All the other changes are only mechanical refactoring, no semantic c= hanges. > >> > >> Signed-off-by: Marcel Apfelbaum > >> --- > >> - I am perfectly aware that patches touching a lot of files > >> are not desirable, but this one is a very simple replacement > >> patch: > >> QEMUMachineInitArgs -> MachineState > >> args -> ms > >> - This is the simplest way to get rid of QEMUMachineInitArgs fast. > >> > > One more thing: > > pc_q35_init() and pc_init1() both use qdev_get_machine() for adding > > properties. Please replace it with passed in machine. >=20 > For the previous series we had clarified that qdev_get_machine() can > safely be used. The benefit of passing "machine" would be efficiency of > machine init only, so let's just do that as a follow-up cleanup please. Fine by me. Thanks, Marcel >=20 > Regards, > Andreas >=20