From: Jiri Pirko <jiri@resnulli.us>
To: qemu-devel@nongnu.org
Cc: dmitry@daynix.com, peter.maydell@linaro.org, dgilbert@redhat.com,
stefanha@redhat.com, mst@redhat.com
Subject: [Qemu-devel] [patch qemu] vmxnet3: fix msix vectors unuse
Date: Mon, 19 May 2014 15:47:16 +0200 [thread overview]
Message-ID: <1400507236-14945-1-git-send-email-jiri@resnulli.us> (raw)
In vmxnet3_cleanup_msix(), there is called msix_vector_unuse() with
VMXNET3_MAX_INTRS. That is not correct since vector of
value VMXNET3_MAX_INTRS was never used. Also all the used vectors
are not un-used. So call vmxnet3_unuse_msix_vectors() instead which
does the correct job.
Signed-off-by: Jiri Pirko <jiri@resnulli.us>
---
hw/net/vmxnet3.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/net/vmxnet3.c b/hw/net/vmxnet3.c
index 1bb9259..f3be494 100644
--- a/hw/net/vmxnet3.c
+++ b/hw/net/vmxnet3.c
@@ -2050,7 +2050,7 @@ vmxnet3_cleanup_msix(VMXNET3State *s)
PCIDevice *d = PCI_DEVICE(s);
if (s->msix_used) {
- msix_vector_unuse(d, VMXNET3_MAX_INTRS);
+ vmxnet3_unuse_msix_vectors(s, VMXNET3_MAX_INTRS);
msix_uninit(d, &s->msix_bar, &s->msix_bar);
}
}
--
1.9.0
next reply other threads:[~2014-05-19 13:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-19 13:47 Jiri Pirko [this message]
2014-05-20 10:49 ` [Qemu-devel] [patch qemu] vmxnet3: fix msix vectors unuse Dmitry Fleytman
2014-05-20 13:25 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1400507236-14945-1-git-send-email-jiri@resnulli.us \
--to=jiri@resnulli.us \
--cc=dgilbert@redhat.com \
--cc=dmitry@daynix.com \
--cc=mst@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).