* [Qemu-devel] [patch qemu] vmxnet3: fix msix vectors unuse
@ 2014-05-19 13:47 Jiri Pirko
2014-05-20 10:49 ` Dmitry Fleytman
2014-05-20 13:25 ` Stefan Hajnoczi
0 siblings, 2 replies; 3+ messages in thread
From: Jiri Pirko @ 2014-05-19 13:47 UTC (permalink / raw)
To: qemu-devel; +Cc: dmitry, peter.maydell, dgilbert, stefanha, mst
In vmxnet3_cleanup_msix(), there is called msix_vector_unuse() with
VMXNET3_MAX_INTRS. That is not correct since vector of
value VMXNET3_MAX_INTRS was never used. Also all the used vectors
are not un-used. So call vmxnet3_unuse_msix_vectors() instead which
does the correct job.
Signed-off-by: Jiri Pirko <jiri@resnulli.us>
---
hw/net/vmxnet3.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/net/vmxnet3.c b/hw/net/vmxnet3.c
index 1bb9259..f3be494 100644
--- a/hw/net/vmxnet3.c
+++ b/hw/net/vmxnet3.c
@@ -2050,7 +2050,7 @@ vmxnet3_cleanup_msix(VMXNET3State *s)
PCIDevice *d = PCI_DEVICE(s);
if (s->msix_used) {
- msix_vector_unuse(d, VMXNET3_MAX_INTRS);
+ vmxnet3_unuse_msix_vectors(s, VMXNET3_MAX_INTRS);
msix_uninit(d, &s->msix_bar, &s->msix_bar);
}
}
--
1.9.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [patch qemu] vmxnet3: fix msix vectors unuse
2014-05-19 13:47 [Qemu-devel] [patch qemu] vmxnet3: fix msix vectors unuse Jiri Pirko
@ 2014-05-20 10:49 ` Dmitry Fleytman
2014-05-20 13:25 ` Stefan Hajnoczi
1 sibling, 0 replies; 3+ messages in thread
From: Dmitry Fleytman @ 2014-05-20 10:49 UTC (permalink / raw)
To: Jiri Pirko; +Cc: peter.maydell, stefanha, qemu-devel, dgilbert, mst
ACK
Thanks for fixing.
On May 19, 2014, at 16:47 PM, Jiri Pirko <jiri@resnulli.us> wrote:
> In vmxnet3_cleanup_msix(), there is called msix_vector_unuse() with
> VMXNET3_MAX_INTRS. That is not correct since vector of
> value VMXNET3_MAX_INTRS was never used. Also all the used vectors
> are not un-used. So call vmxnet3_unuse_msix_vectors() instead which
> does the correct job.
>
> Signed-off-by: Jiri Pirko <jiri@resnulli.us>
> ---
> hw/net/vmxnet3.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/net/vmxnet3.c b/hw/net/vmxnet3.c
> index 1bb9259..f3be494 100644
> --- a/hw/net/vmxnet3.c
> +++ b/hw/net/vmxnet3.c
> @@ -2050,7 +2050,7 @@ vmxnet3_cleanup_msix(VMXNET3State *s)
> PCIDevice *d = PCI_DEVICE(s);
>
> if (s->msix_used) {
> - msix_vector_unuse(d, VMXNET3_MAX_INTRS);
> + vmxnet3_unuse_msix_vectors(s, VMXNET3_MAX_INTRS);
> msix_uninit(d, &s->msix_bar, &s->msix_bar);
> }
> }
> --
> 1.9.0
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [patch qemu] vmxnet3: fix msix vectors unuse
2014-05-19 13:47 [Qemu-devel] [patch qemu] vmxnet3: fix msix vectors unuse Jiri Pirko
2014-05-20 10:49 ` Dmitry Fleytman
@ 2014-05-20 13:25 ` Stefan Hajnoczi
1 sibling, 0 replies; 3+ messages in thread
From: Stefan Hajnoczi @ 2014-05-20 13:25 UTC (permalink / raw)
To: Jiri Pirko; +Cc: dmitry, peter.maydell, qemu-devel, dgilbert, mst
On Mon, May 19, 2014 at 03:47:16PM +0200, Jiri Pirko wrote:
> In vmxnet3_cleanup_msix(), there is called msix_vector_unuse() with
> VMXNET3_MAX_INTRS. That is not correct since vector of
> value VMXNET3_MAX_INTRS was never used. Also all the used vectors
> are not un-used. So call vmxnet3_unuse_msix_vectors() instead which
> does the correct job.
>
> Signed-off-by: Jiri Pirko <jiri@resnulli.us>
> ---
> hw/net/vmxnet3.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Thanks, applied to my net tree:
https://github.com/stefanha/qemu/commits/net
Stefan
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-05-20 13:25 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-05-19 13:47 [Qemu-devel] [patch qemu] vmxnet3: fix msix vectors unuse Jiri Pirko
2014-05-20 10:49 ` Dmitry Fleytman
2014-05-20 13:25 ` Stefan Hajnoczi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).