From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45047) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WmNuY-000833-2x for qemu-devel@nongnu.org; Mon, 19 May 2014 09:47:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WmNuR-0006tn-Vg for qemu-devel@nongnu.org; Mon, 19 May 2014 09:47:26 -0400 Received: from mail-ee0-f43.google.com ([74.125.83.43]:36628) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WmNuR-0006ta-Po for qemu-devel@nongnu.org; Mon, 19 May 2014 09:47:19 -0400 Received: by mail-ee0-f43.google.com with SMTP id d17so3666334eek.30 for ; Mon, 19 May 2014 06:47:18 -0700 (PDT) From: Jiri Pirko Date: Mon, 19 May 2014 15:47:16 +0200 Message-Id: <1400507236-14945-1-git-send-email-jiri@resnulli.us> Subject: [Qemu-devel] [patch qemu] vmxnet3: fix msix vectors unuse List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: dmitry@daynix.com, peter.maydell@linaro.org, dgilbert@redhat.com, stefanha@redhat.com, mst@redhat.com In vmxnet3_cleanup_msix(), there is called msix_vector_unuse() with VMXNET3_MAX_INTRS. That is not correct since vector of value VMXNET3_MAX_INTRS was never used. Also all the used vectors are not un-used. So call vmxnet3_unuse_msix_vectors() instead which does the correct job. Signed-off-by: Jiri Pirko --- hw/net/vmxnet3.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/net/vmxnet3.c b/hw/net/vmxnet3.c index 1bb9259..f3be494 100644 --- a/hw/net/vmxnet3.c +++ b/hw/net/vmxnet3.c @@ -2050,7 +2050,7 @@ vmxnet3_cleanup_msix(VMXNET3State *s) PCIDevice *d = PCI_DEVICE(s); if (s->msix_used) { - msix_vector_unuse(d, VMXNET3_MAX_INTRS); + vmxnet3_unuse_msix_vectors(s, VMXNET3_MAX_INTRS); msix_uninit(d, &s->msix_bar, &s->msix_bar); } } -- 1.9.0