* [Qemu-devel] [PATCH] qcow2: Fix memory leak in COW error path
@ 2014-05-19 15:56 Kevin Wolf
2014-05-20 13:33 ` Stefan Hajnoczi
0 siblings, 1 reply; 2+ messages in thread
From: Kevin Wolf @ 2014-05-19 15:56 UTC (permalink / raw)
To: qemu-devel; +Cc: kwolf, stefanha, mreitz
This triggers if bs->drv becomes NULL in a concurrent request. This is
currently only the case when corruption prevention kicks in (i.e. at
most once per image, and after that it produces I/O errors).
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
---
block/qcow2-cluster.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/block/qcow2-cluster.c b/block/qcow2-cluster.c
index 76d2bcf..4208dc0 100644
--- a/block/qcow2-cluster.c
+++ b/block/qcow2-cluster.c
@@ -379,7 +379,8 @@ static int coroutine_fn copy_sectors(BlockDriverState *bs,
BLKDBG_EVENT(bs->file, BLKDBG_COW_READ);
if (!bs->drv) {
- return -ENOMEDIUM;
+ ret = -ENOMEDIUM;
+ goto out;
}
/* Call .bdrv_co_readv() directly instead of using the public block-layer
--
1.8.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [PATCH] qcow2: Fix memory leak in COW error path
2014-05-19 15:56 [Qemu-devel] [PATCH] qcow2: Fix memory leak in COW error path Kevin Wolf
@ 2014-05-20 13:33 ` Stefan Hajnoczi
0 siblings, 0 replies; 2+ messages in thread
From: Stefan Hajnoczi @ 2014-05-20 13:33 UTC (permalink / raw)
To: Kevin Wolf; +Cc: qemu-devel, mreitz
On Mon, May 19, 2014 at 05:56:01PM +0200, Kevin Wolf wrote:
> This triggers if bs->drv becomes NULL in a concurrent request. This is
> currently only the case when corruption prevention kicks in (i.e. at
> most once per image, and after that it produces I/O errors).
>
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
> block/qcow2-cluster.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
Thanks, applied to my block tree:
https://github.com/stefanha/qemu/commits/block
Stefan
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-05-20 13:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-05-19 15:56 [Qemu-devel] [PATCH] qcow2: Fix memory leak in COW error path Kevin Wolf
2014-05-20 13:33 ` Stefan Hajnoczi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).