From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54984) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WmWaz-00010a-U4 for qemu-devel@nongnu.org; Mon, 19 May 2014 19:03:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WmWat-0006f7-Ro for qemu-devel@nongnu.org; Mon, 19 May 2014 19:03:49 -0400 Received: from mail-we0-x235.google.com ([2a00:1450:400c:c03::235]:60460) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WmWat-0006eW-Lk for qemu-devel@nongnu.org; Mon, 19 May 2014 19:03:43 -0400 Received: by mail-we0-f181.google.com with SMTP id w61so6031335wes.26 for ; Mon, 19 May 2014 16:03:42 -0700 (PDT) From: Hani Benhabiles Date: Tue, 20 May 2014 00:03:17 +0100 Message-Id: <1400540600-1328-5-git-send-email-kroosec@gmail.com> In-Reply-To: <1400540600-1328-1-git-send-email-kroosec@gmail.com> References: <1400540600-1328-1-git-send-email-kroosec@gmail.com> Subject: [Qemu-devel] [PATCH 4/7] monitor: Add host_net_add device argument completion. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kwolf@redhat.com, mdroth@linux.vnet.ibm.com, lcapitulino@redhat.com, stefanha@redhat.com, imammedo@redhat.com Also fix the parameters documentation. Signed-off-by: Hani Benhabiles --- hmp-commands.hx | 3 ++- hmp.h | 1 + monitor.c | 14 ++++++++++++++ 3 files changed, 17 insertions(+), 1 deletion(-) diff --git a/hmp-commands.hx b/hmp-commands.hx index 919af6e..6aaec1b 100644 --- a/hmp-commands.hx +++ b/hmp-commands.hx @@ -1209,9 +1209,10 @@ ETEXI { .name = "host_net_add", .args_type = "device:s,opts:s?", - .params = "tap|user|socket|vde|netmap|dump [options]", + .params = "tap|user|socket|vde|bridge|dump [options]", .help = "add host VLAN client", .mhandler.cmd = net_host_device_add, + .command_completion = host_net_add_completion, }, STEXI diff --git a/hmp.h b/hmp.h index 0c814d0..22ee836 100644 --- a/hmp.h +++ b/hmp.h @@ -109,5 +109,6 @@ void watchdog_action_completion(ReadLineState *rs, int nb_args, const char *str); void migrate_set_capability_completion(ReadLineState *rs, int nb_args, const char *str); +void host_net_add_completion(ReadLineState *rs, int nb_args, const char *str); #endif diff --git a/monitor.c b/monitor.c index 6a3a5c9..365c66a 100644 --- a/monitor.c +++ b/monitor.c @@ -4593,6 +4593,20 @@ void migrate_set_capability_completion(ReadLineState *rs, int nb_args, } } +void host_net_add_completion(ReadLineState *rs, int nb_args, const char *str) +{ + if (nb_args != 2) { + return; + } + readline_set_completion_index(rs, strlen(str)); + add_completion_option(rs, str, "tap"); + add_completion_option(rs, str, "user"); + add_completion_option(rs, str, "socket"); + add_completion_option(rs, str, "vde"); + add_completion_option(rs, str, "dump"); + add_completion_option(rs, str, "bridge"); +} + static void monitor_find_completion_by_table(Monitor *mon, const mon_cmd_t *cmd_table, char **args, -- 1.8.3.2