qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Hani Benhabiles <kroosec@gmail.com>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, mdroth@linux.vnet.ibm.com,
	lcapitulino@redhat.com, stefanha@redhat.com, imammedo@redhat.com
Subject: [Qemu-devel] [PATCH 5/7] readline: Make completion strings always unique.
Date: Tue, 20 May 2014 00:03:18 +0100	[thread overview]
Message-ID: <1400540600-1328-6-git-send-email-kroosec@gmail.com> (raw)
In-Reply-To: <1400540600-1328-1-git-send-email-kroosec@gmail.com>

There is no need to clutter the user's choices with repeating the same value
multiple times.

Signed-off-by: Hani Benhabiles <hani@linux.com>
---
 util/readline.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/util/readline.c b/util/readline.c
index 8baec55..7214e84 100644
--- a/util/readline.c
+++ b/util/readline.c
@@ -263,6 +263,12 @@ static void readline_hist_add(ReadLineState *rs, const char *cmdline)
 void readline_add_completion(ReadLineState *rs, const char *str)
 {
     if (rs->nb_completions < READLINE_MAX_COMPLETIONS) {
+        int i;
+        for (i = 0; i < rs->nb_completions; i++) {
+            if (!strcmp(rs->completions[i], str)) {
+                return;
+            }
+        }
         rs->completions[rs->nb_completions++] = g_strdup(str);
     }
 }
-- 
1.8.3.2

  parent reply	other threads:[~2014-05-19 23:03 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-19 23:03 [Qemu-devel] monitor: Command completion for various commands Hani Benhabiles
2014-05-19 23:03 ` [Qemu-devel] [PATCH 1/7] monitor: Add ringbuf_write and ringbuf_read argument completion Hani Benhabiles
2014-05-19 23:03 ` [Qemu-devel] [PATCH 2/7] monitor: Add watchdog_action " Hani Benhabiles
2014-05-19 23:03 ` [Qemu-devel] [PATCH 3/7] monitor: Add migrate_set_capability completion Hani Benhabiles
2014-05-21 18:42   ` Dr. David Alan Gilbert
2014-05-22  7:05     ` Markus Armbruster
2014-05-19 23:03 ` [Qemu-devel] [PATCH 4/7] monitor: Add host_net_add device argument completion Hani Benhabiles
2014-05-23 12:05   ` Stefan Hajnoczi
2014-05-25 16:12     ` Hani Benhabiles
2014-05-26  9:20       ` Stefan Hajnoczi
2014-05-19 23:03 ` Hani Benhabiles [this message]
2014-05-19 23:03 ` [Qemu-devel] [PATCH 6/7] monitor: Add host_net_remove arguments completion Hani Benhabiles
2014-05-23 12:09   ` Stefan Hajnoczi
2014-05-19 23:03 ` [Qemu-devel] [PATCH 7/7] monitor: Add delvm and loadvm argument completion Hani Benhabiles

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1400540600-1328-6-git-send-email-kroosec@gmail.com \
    --to=kroosec@gmail.com \
    --cc=imammedo@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=lcapitulino@redhat.com \
    --cc=mdroth@linux.vnet.ibm.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).