From: Gerd Hoffmann <kraxel@redhat.com>
To: "Dr. David Alan Gilbert (git)" <dgilbert@redhat.com>
Cc: armbru@redhat.com, mst@redhat.com, qemu-devel@nongnu.org,
aliguori@amazon.com, rjones@redhat.com
Subject: Re: [Qemu-devel] [PATCH] -machine vmport=off: Allow disabling of VMWare ioport emulation
Date: Tue, 20 May 2014 09:40:40 +0200 [thread overview]
Message-ID: <1400571640.10626.7.camel@nilsson.home.kraxel.org> (raw)
In-Reply-To: <1400518826-19144-1-git-send-email-dgilbert@redhat.com>
> /* init basic PC hardware */
> - pc_basic_device_init(isa_bus, gsi, &rtc_state, &floppy, xen_enabled(),
> - 0x4);
> + pc_basic_device_init(isa_bus, gsi, &rtc_state, &floppy,
> + !qemu_opt_get_bool(qemu_get_machine_opts(), "vmport",
> + true) || xen_enabled(), 0x4);
pc_basic_device_init
(isa_bus, gsi, &rtc_state, &floppy,
!qemu_opt_get_bool(qemu_get_machine_opts(),"vmport",!xen_enabled()),
0x4);
?
This makes vmport switchable on xen too, with traditional behavior being
the default (off on xen, on otherwise).
cheers,
Gerd
next prev parent reply other threads:[~2014-05-20 7:41 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-19 17:00 [Qemu-devel] [PATCH] -machine vmport=off: Allow disabling of VMWare ioport emulation Dr. David Alan Gilbert (git)
2014-05-19 17:03 ` Richard W.M. Jones
2014-05-20 7:40 ` Gerd Hoffmann [this message]
2014-05-20 8:47 ` Dr. David Alan Gilbert
2014-05-20 9:18 ` Richard W.M. Jones
2014-05-20 10:10 ` Gerd Hoffmann
2014-09-25 13:40 ` Slutz, Donald Christopher
2014-09-25 15:07 ` Dr. David Alan Gilbert
2014-09-25 17:47 ` Slutz, Donald Christopher
2014-09-25 18:00 ` Dr. David Alan Gilbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1400571640.10626.7.camel@nilsson.home.kraxel.org \
--to=kraxel@redhat.com \
--cc=aliguori@amazon.com \
--cc=armbru@redhat.com \
--cc=dgilbert@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rjones@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).