From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:55590)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1WmefO-00063j-7z
	for qemu-devel@nongnu.org; Tue, 20 May 2014 03:41:00 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1WmefI-000535-3P
	for qemu-devel@nongnu.org; Tue, 20 May 2014 03:40:54 -0400
Received: from mx1.redhat.com ([209.132.183.28]:40440)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1WmefH-00052u-SF
	for qemu-devel@nongnu.org; Tue, 20 May 2014 03:40:48 -0400
Message-ID: <1400571640.10626.7.camel@nilsson.home.kraxel.org>
From: Gerd Hoffmann <kraxel@redhat.com>
Date: Tue, 20 May 2014 09:40:40 +0200
In-Reply-To: <1400518826-19144-1-git-send-email-dgilbert@redhat.com>
References: <1400518826-19144-1-git-send-email-dgilbert@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] -machine vmport=off: Allow disabling of
 VMWare ioport emulation
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Dr. David Alan Gilbert (git)" <dgilbert@redhat.com>
Cc: armbru@redhat.com, mst@redhat.com, qemu-devel@nongnu.org, aliguori@amazon.com, rjones@redhat.com

>      /* init basic PC hardware */
> -    pc_basic_device_init(isa_bus, gsi, &rtc_state, &floppy, xen_enabled(),
> -        0x4);
> +    pc_basic_device_init(isa_bus, gsi, &rtc_state, &floppy,
> +                         !qemu_opt_get_bool(qemu_get_machine_opts(), "vmport",
> +                                            true) || xen_enabled(), 0x4);

pc_basic_device_init
  (isa_bus, gsi, &rtc_state, &floppy,
   !qemu_opt_get_bool(qemu_get_machine_opts(),"vmport",!xen_enabled()),
   0x4);

?

This makes vmport switchable on xen too, with traditional behavior being
the default (off on xen, on otherwise).

cheers,
  Gerd