From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48238) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WmiAD-0006kz-AF for qemu-devel@nongnu.org; Tue, 20 May 2014 07:25:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WmiA0-0002Sv-G3 for qemu-devel@nongnu.org; Tue, 20 May 2014 07:24:57 -0400 Received: from mx1.redhat.com ([209.132.183.28]:9376) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WmiA0-0002SR-8n for qemu-devel@nongnu.org; Tue, 20 May 2014 07:24:44 -0400 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s4KBOhAu027357 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 20 May 2014 07:24:43 -0400 From: Gerd Hoffmann Date: Tue, 20 May 2014 13:24:21 +0200 Message-Id: <1400585062-13260-2-git-send-email-kraxel@redhat.com> In-Reply-To: <1400585062-13260-1-git-send-email-kraxel@redhat.com> References: <1400585062-13260-1-git-send-email-kraxel@redhat.com> Subject: [Qemu-devel] [PATCH 2/3] usb-mtp: handle lseek failure List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Gerd Hoffmann , "Dr. David Alan Gilbert" Cc: Dr. David Alan Gilbert Signed-off-by: Gerd Hoffmann --- hw/usb/dev-mtp.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/hw/usb/dev-mtp.c b/hw/usb/dev-mtp.c index c2750e4..a95298b 100644 --- a/hw/usb/dev-mtp.c +++ b/hw/usb/dev-mtp.c @@ -702,7 +702,10 @@ static MTPData *usb_mtp_get_partial_object(MTPState *s, MTPControl *c, if (offset > o->stat.st_size) { offset = o->stat.st_size; } - lseek(d->fd, offset, SEEK_SET); + if (lseek(d->fd, offset, SEEK_SET) < 0) { + usb_mtp_data_free(d); + return NULL; + } d->length = c->argv[2]; if (d->length > o->stat.st_size - offset) { -- 1.8.3.1