From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38013) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wmo9S-0005R1-Sb for qemu-devel@nongnu.org; Tue, 20 May 2014 13:48:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wmo9J-0004x1-J1 for qemu-devel@nongnu.org; Tue, 20 May 2014 13:48:34 -0400 Received: from mail-pb0-x231.google.com ([2607:f8b0:400e:c01::231]:65352) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wmo9J-0004wE-5G for qemu-devel@nongnu.org; Tue, 20 May 2014 13:48:25 -0400 Received: by mail-pb0-f49.google.com with SMTP id jt11so530408pbb.22 for ; Tue, 20 May 2014 10:48:23 -0700 (PDT) From: Sanidhya Kashyap Date: Tue, 20 May 2014 23:17:54 +0530 Message-Id: <1400608075-19917-6-git-send-email-sanidhya.iiith@gmail.com> In-Reply-To: <1400608075-19917-1-git-send-email-sanidhya.iiith@gmail.com> References: <1400608075-19917-1-git-send-email-sanidhya.iiith@gmail.com> Subject: [Qemu-devel] [PATCH 5/6] set the frequency of the dump bitmap process List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu list Cc: Juan Quintela This patch introduces both qmp and hmp (log-dirty-bitmap-set-frequency) interface to update the value of the frequency. Signed-off-by: Sanidhya Kashyap --- hmp-commands.hx | 15 +++++++++++++++ hmp.c | 12 ++++++++++++ hmp.h | 1 + qapi-schema.json | 8 ++++++++ qmp-commands.hx | 23 +++++++++++++++++++++++ savevm.c | 7 +++++++ 6 files changed, 66 insertions(+) diff --git a/hmp-commands.hx b/hmp-commands.hx index a8e13b3..38c1b9d 100644 --- a/hmp-commands.hx +++ b/hmp-commands.hx @@ -1805,6 +1805,21 @@ STEXI Cancel the current VM migration. ETEXI + { + .name = "ldbsf|log-dirty-bitmap-set-frequency", + .args_type = "frequency:i", + .params = "frequency", + .help = "set the frequency for memory logging\n\t\t\t" + "frequency: the new frequency value to replace the existing", + .mhandler.cmd = hmp_log_dirty_bitmap_set_frequency, + }, + +STEXI +@item ldbsf or log-dirty-bitmap-set-frequency @var{frequency} +@findex log-dirty-bitmap-set-frequency +Set the frequency to @var{frequency} (int) for memory logging. +ETEXI + STEXI @end table ETEXI diff --git a/hmp.c b/hmp.c index 7bbbaad..297db3d 100644 --- a/hmp.c +++ b/hmp.c @@ -1333,6 +1333,18 @@ void hmp_log_dirty_bitmap_cancel(Monitor *mon, const QDict *qdict) qmp_log_dirty_bitmap_cancel(NULL); } +void hmp_log_dirty_bitmap_set_frequency(Monitor *mon, const QDict *qdict) +{ + int64_t frequency = qdict_get_int(qdict, "frequency"); + Error *err = NULL; + qmp_log_dirty_bitmap_set_frequency(frequency, &err); + if (err) { + monitor_printf(mon, "log-dirty-bitmap-set-frequency: %s\n", + error_get_pretty(err)); + error_free(err); + } +} + void hmp_dump_guest_memory(Monitor *mon, const QDict *qdict) { Error *err = NULL; diff --git a/hmp.h b/hmp.h index d98b2ae..21d5e88 100644 --- a/hmp.h +++ b/hmp.h @@ -95,6 +95,7 @@ void hmp_object_add(Monitor *mon, const QDict *qdict); void hmp_object_del(Monitor *mon, const QDict *qdict); void hmp_log_dirty_bitmap(Monitor *mon, const QDict *qdict); void hmp_log_dirty_bitmap_cancel(Monitor *mon, const QDict *qdict); +void hmp_log_dirty_bitmap_set_frequency(Monitor *mon, const QDict *qdict); void object_add_completion(ReadLineState *rs, int nb_args, const char *str); void object_del_completion(ReadLineState *rs, int nb_args, const char *str); void device_add_completion(ReadLineState *rs, int nb_args, const char *str); diff --git a/qapi-schema.json b/qapi-schema.json index e897adb..ccef4d8 100644 --- a/qapi-schema.json +++ b/qapi-schema.json @@ -4715,3 +4715,11 @@ # cancel the dirty bitmap logging process ## { 'command': 'log-dirty-bitmap-cancel' } + +## @log-dirty-bitmap-set-frequency +# +# sets the frequency of the dirty bitmap logging process +## +{ 'command': 'log-dirty-bitmap-set-frequency', + 'data': {'frequency': 'int' } } + diff --git a/qmp-commands.hx b/qmp-commands.hx index 55b2251..fe12d05 100644 --- a/qmp-commands.hx +++ b/qmp-commands.hx @@ -3623,3 +3623,26 @@ Example: <- { "return": {} } EQMP + + { + .name = "log-dirty-bitmap-set-frequency", + .args_type = "frequency:i", + .mhandler.cmd_new = qmp_marshal_input_log_dirty_bitmap_set_frequency, + }, + +SQMP +log-dirty-bitmap-set-frequency +-------------------- + +Update the frequency for the remaining epochs. + +Arguments: + +- "frequency": the updated frequency (json-int) + +Example: + +-> { "execute": "log-dirty-bitmap-set-frequency", "arguments": { "value": 1024 } } +<- { "return": {} } + +EQMP diff --git a/savevm.c b/savevm.c index 1859f57..7551891 100644 --- a/savevm.c +++ b/savevm.c @@ -1339,6 +1339,13 @@ void qmp_log_dirty_bitmap_cancel(Error **errp) logging_bitmap_cancel(logging_current_state()); } +void qmp_log_dirty_bitmap_set_frequency(int64_t frequency, Error **errp) +{ + BitmapLogState *b = logging_current_state(); + check_frequency_value(&frequency, errp); + b->current_frequency = frequency; +} + void qmp_xen_save_devices_state(const char *filename, Error **errp) { QEMUFile *f; -- 1.8.3.1