From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43803) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WmoZ1-0008Gx-EK for qemu-devel@nongnu.org; Tue, 20 May 2014 14:15:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WmoYs-0005Vp-ET for qemu-devel@nongnu.org; Tue, 20 May 2014 14:14:59 -0400 Received: from mail-ee0-x22f.google.com ([2a00:1450:4013:c00::22f]:54906) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WmoYs-0005Vb-7P for qemu-devel@nongnu.org; Tue, 20 May 2014 14:14:50 -0400 Received: by mail-ee0-f47.google.com with SMTP id c13so857987eek.34 for ; Tue, 20 May 2014 11:14:49 -0700 (PDT) Sender: Paolo Bonzini From: Paolo Bonzini Date: Tue, 20 May 2014 20:14:39 +0200 Message-Id: <1400609682-22166-2-git-send-email-pbonzini@redhat.com> In-Reply-To: <1400609682-22166-1-git-send-email-pbonzini@redhat.com> References: <1400609682-22166-1-git-send-email-pbonzini@redhat.com> Subject: [Qemu-devel] [PULL 1/4] scsi: Document intentional fall through in scsi_req_length() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Markus Armbruster From: Markus Armbruster For clarity, and to hush up Coverity. Signed-off-by: Markus Armbruster Signed-off-by: Paolo Bonzini --- hw/scsi/scsi-bus.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/scsi/scsi-bus.c b/hw/scsi/scsi-bus.c index ae921a6..26770fb 100644 --- a/hw/scsi/scsi-bus.c +++ b/hw/scsi/scsi-bus.c @@ -938,6 +938,7 @@ static int scsi_req_length(SCSICommand *cmd, SCSIDevice *dev, uint8_t *buf) if (cmd->xfer == 0) { cmd->xfer = 256; } + /* fall through */ case WRITE_10: case WRITE_VERIFY_10: case WRITE_12: @@ -952,6 +953,7 @@ static int scsi_req_length(SCSICommand *cmd, SCSIDevice *dev, uint8_t *buf) if (cmd->xfer == 0) { cmd->xfer = 256; } + /* fall through */ case READ_10: case RECOVER_BUFFERED_DATA: case READ_12: -- 1.8.3.1